From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/1] OMAP3: add boot status GPIO LED for IGEP boards
Date: Mon, 24 Dec 2012 09:31:59 +0200 [thread overview]
Message-ID: <50D804EF.1070509@compulab.co.il> (raw)
In-Reply-To: <20121224003915.37FB4202BF3@gemini.denx.de>
On 12/24/12 02:39, Wolfgang Denk wrote:
> Dear Javier Martinez Canillas,
>
> In message <1356265899-18669-1-git-send-email-javier.martinez@collabora.co.uk> you wrote:
>> This patch adds an GPIO LED boot status for IGEP boards.
>>
>> The GPIO LED used is the red LED0 while the Linux kernel
>> uses the green LED0 as the boot status.
>>
>> By using different GPIO LEDs, the user can know in which
>> step of the boot process the board currently is.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> Do we really need yet another implementation of boot status
> signalling? I think no.
>
> Please implement this a board specific version of the
> show_boot_progress() feature (see CONFIG_SHOW_BOOT_PROGRESS).
That sounds reasonable.
Although, I don't know if there are appropriate check points implemented,
but certainly, that is the way to go.
--
Regards,
Igor.
next prev parent reply other threads:[~2012-12-24 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-23 12:31 [U-Boot] [PATCH v2 1/1] OMAP3: add boot status GPIO LED for IGEP boards Javier Martinez Canillas
2012-12-23 14:18 ` Igor Grinberg
2012-12-24 0:39 ` Wolfgang Denk
2012-12-24 7:31 ` Igor Grinberg [this message]
2012-12-24 11:51 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D804EF.1070509@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox