From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Thu, 27 Dec 2012 10:33:23 +0100
Subject: [U-Boot] [PATCH 1/9] mx28evk: We shouldn't hardcode a rootfs
 filesystem type
In-Reply-To: <CAP9ODKo2AHymdTnMagM03BOxFVJZoaWq6vENeYGn+Ho=QvH7Cw@mail.gmail.com>
References: <1356109151-6623-1-git-send-email-otavio@ossystems.com.br>
	<1356109151-6623-2-git-send-email-otavio@ossystems.com.br>
	<50DAD950.6060103@denx.de>
	<CAP9ODKo2AHymdTnMagM03BOxFVJZoaWq6vENeYGn+Ho=QvH7Cw@mail.gmail.com>
Message-ID: <50DC15E3.2040003@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 26/12/2012 19:17, Otavio Salvador wrote:
> On Wed, Dec 26, 2012 at 9:02 AM, Stefano Babic <sbabic@denx.de> wrote:
>> On 21/12/2012 17:59, Otavio Salvador wrote:
>>> For a generic environment, we shouldn't have a fixed rootfs filesystem
>>> so we drop it from env.
>>>
>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>> ---

Hi Otavio,


>>
>>>  include/configs/mx28evk.h |    7 ++-----
>>>  1 file changed, 2 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
>>> index 8b89b25..3cc0726 100644
>>> --- a/include/configs/mx28evk.h
>>> +++ b/include/configs/mx28evk.h
>>> @@ -292,11 +292,8 @@
>>>       "console_mainline=ttyAMA0\0" \
>>>       "mmcdev=0\0" \
>>>       "mmcpart=2\0" \
>>> -     "mmcroot=/dev/mmcblk0p3 rw\0" \
>>> -     "mmcrootfstype=ext3 rootwait\0" \
>>> -     "mmcargs=setenv bootargs console=${console_mainline},${baudrate} " \
>>> -             "root=${mmcroot} " \
>>> -             "rootfstype=${mmcrootfstype}\0" \
>>> +     "mmcroot=/dev/mmcblk0p3 rw rootwait\0" \
>>> +     "mmcargs=setenv bootargs console=${console_mainline},${baudrate} root=${mmcroot}\0" \
>>>       "loadbootscript="  \
>>>               "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
>>>       "bootscript=echo Running bootscript from mmc ...; "     \
>>>
>>
>> WARNING: line over 80 characters
>> #37: FILE: include/configs/mx28evk.h:296:
>> +       "mmcargs=setenv bootargs console=${console_mainline},${baudrate}
>> root=${mmcroot}\0" \
>>
>> total: 0 errors, 1 warnings, 13 lines checked
>>
>> Can you fix it ?
> 
> Yes but I think it'd be more confusing for someone reading the code.
> If you do want me to fix it, I do.

Well, I think you can add extra tabs to make it more readable:

+       "mmcargs=setenv bootargs console=${console_mainline},"\
+		" ${baudrate} root=${mmcroot}\0" \

This solution is also in other boards - if we let these warnings, I know
that some periodic checks in the code will raise the warnings again.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================