From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx53loco: Call PMIC related functions from board_late_init()
Date: Thu, 27 Dec 2012 11:09:39 +0100 [thread overview]
Message-ID: <50DC1E63.1000903@denx.de> (raw)
In-Reply-To: <1356537020-31114-1-git-send-email-festevam@gmail.com>
On 26/12/2012 16:50, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit c733681 (pmic: Extend PMIC framework to support multiple instances
> of PMIC devices) mx53loco fails to allocate the memory for PMIC:
>
> U-Boot 2013.01-rc2-dirty (Dec 20 2012 - 15:55:01)
>
> Board: MX53 LOCO
> I2C: ready
> DRAM: 1 GiB
> pmic_alloc: No available memory for allocation!
> pmic_init: POWER allocation error!
> CPU: Freescale i.MX53 family rev2.0 at 800 MHz
> Reset cause: POR
> MMC: FSL_SDHC: 0, FSL_SDHC: 1
>
> Calling the PMIC related functions at a later stage, ie, from board_late_init()
> fixes the issue.
>
> Reported-by: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Hi Fabio, hi Robert,
the new pmic framework calls malloc(), that the reason. It is then safe
to call the init from board_late_init().
Tested-by: Stefano Babic <sbabic@denx.de>
Applied to u-boot-imx, thanks.
gcc 4.6.4, it boots always here.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2012-12-27 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-26 15:50 [U-Boot] [PATCH] mx53loco: Call PMIC related functions from board_late_init() Fabio Estevam
2012-12-27 10:09 ` Stefano Babic [this message]
2012-12-27 10:14 ` Fabio Estevam
2012-12-27 10:24 ` Stefano Babic
2012-12-27 16:27 ` Albert ARIBAUD
2012-12-28 8:38 ` Stefano Babic
2012-12-28 10:34 ` Albert ARIBAUD
2012-12-28 12:15 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DC1E63.1000903@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox