* [U-Boot] [PATCH v2] mmc: fsl_esdhc: Use calloc()
@ 2012-12-27 18:51 Fabio Estevam
2012-12-27 21:53 ` Jeroen Hofstee
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2012-12-27 18:51 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
A malloc() followed by memset() can be simply replaced by calloc().
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Change since v1:
- Fix commit log
drivers/mmc/fsl_esdhc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
index e93e38a..5fc1c36 100644
--- a/drivers/mmc/fsl_esdhc.c
+++ b/drivers/mmc/fsl_esdhc.c
@@ -595,8 +595,7 @@ int fsl_esdhc_mmc_init(bd_t *bis)
{
struct fsl_esdhc_cfg *cfg;
- cfg = malloc(sizeof(struct fsl_esdhc_cfg));
- memset(cfg, 0, sizeof(struct fsl_esdhc_cfg));
+ cfg = calloc(sizeof(struct fsl_esdhc_cfg), 1);
cfg->esdhc_base = CONFIG_SYS_FSL_ESDHC_ADDR;
cfg->sdhc_clk = gd->sdhc_clk;
return fsl_esdhc_initialize(bis, cfg);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* [U-Boot] [PATCH v2] mmc: fsl_esdhc: Use calloc()
2012-12-27 18:51 [U-Boot] [PATCH v2] mmc: fsl_esdhc: Use calloc() Fabio Estevam
@ 2012-12-27 21:53 ` Jeroen Hofstee
0 siblings, 0 replies; 2+ messages in thread
From: Jeroen Hofstee @ 2012-12-27 21:53 UTC (permalink / raw)
To: u-boot
On 12/27/2012 07:51 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> A malloc() followed by memset() can be simply replaced by calloc().
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Change since v1:
> - Fix commit log
> drivers/mmc/fsl_esdhc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index e93e38a..5fc1c36 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -595,8 +595,7 @@ int fsl_esdhc_mmc_init(bd_t *bis)
> {
> struct fsl_esdhc_cfg *cfg;
>
> - cfg = malloc(sizeof(struct fsl_esdhc_cfg));
> - memset(cfg, 0, sizeof(struct fsl_esdhc_cfg));
> + cfg = calloc(sizeof(struct fsl_esdhc_cfg), 1);
> cfg->esdhc_base = CONFIG_SYS_FSL_ESDHC_ADDR;
> cfg->sdhc_clk = gd->sdhc_clk;
> return fsl_esdhc_initialize(bis, cfg);
nitpicking: if you're cleaning up, why not swap the arguments to calloc ;)
Regards,
Jeroen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-27 21:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-27 18:51 [U-Boot] [PATCH v2] mmc: fsl_esdhc: Use calloc() Fabio Estevam
2012-12-27 21:53 ` Jeroen Hofstee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox