From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/15] fdt: Use sed instead of cpp to pre-process the dtc
Date: Fri, 28 Dec 2012 16:47:43 -0700 [thread overview]
Message-ID: <50DE2F9F.9000706@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ3kNLa3O5fMRt5K+QNhTPrZC+pBMDOEBanj5uSMJT1=pQ@mail.gmail.com>
On 12/28/2012 11:07 AM, Simon Glass wrote:
> Hi,
>
> On Fri, Dec 28, 2012 at 8:42 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>> On Friday 28 December 2012 09:55:52 Simon Glass wrote:
>>> On Thu, Dec 27, 2012 at 4:03 PM, Stephen Warren wrote:
>>>> On 12/26/2012 03:28 PM, Simon Glass wrote:
>>>>> Include file support in dtc is still not available in common
>>>>> distributions so we need to keep our preprocessing arrangement around
>>>>> for a little longer.
>>>>>
>>>>> But # is commonly used in FDT files, so use sed instead of cpp for this
>>>>> preprocessing.
>>>>
>>>> This sounds like the wrong approach to me. I'd suggest using what I
>>>>
>>>> proposed for the kernel:
>>>>> cmd_dtc_cpp = $(CPP) $(cpp_flags) -D__DTS__ -x assembler-with-cpp -o
>>>>> $(dtc-tmp) $< ; \
>>>>>
>>>>> $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 $(DTC_FLAGS)
>>>>> $(dtc-tmp)
>>>>
>>>> The "-x assembler-with-cpp" is what solves the # problem IIRC.
>>>
>>> I originally used CPP as an expedient means of converting the
>>> ARCH_CPU_DTS symbol until we all have a dtc with include path support.
>>>
>>> Are you saying that we want to actually use the CPP on tthe device
>>> tree and (presumably) use U-Boot include files within the FDT?
Yes, I'd explicitly like to be able to use C-style header files to
define named constants etc.
>> sounds reasonable to me. we already do it with linker scripts, and if the
>> kernel is doing it, it means we can (possibly) share more.
>
> OK. Stephen, what is the kernel actually doing with the preprocessor?
> Have you given up on the dtc symbol stuff for now and plan to use CPP
> instead?
Yes, I've given up on getting any kind of pre-processor or macro
language into dtc itself. I haven't managed to get the kernel to accept
the logic I quoted above either yet; this has all been a very long and
tortuous process. I hope to repost the patch that implements this in the
kernel within the next week or so.
next prev parent reply other threads:[~2012-12-28 23:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-26 22:28 [U-Boot] [PATCH 0/15] Enhance SPI/SPI flash probing, add support for Intel ICH controller Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 01/15] fdt: Use sed instead of cpp to pre-process the dtc Simon Glass
2012-12-28 0:03 ` Stephen Warren
2012-12-28 14:55 ` Simon Glass
2012-12-28 16:42 ` Mike Frysinger
2012-12-28 18:07 ` Simon Glass
2012-12-28 23:47 ` Stephen Warren [this message]
2012-12-29 0:34 ` Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 02/15] fdt: Add fdtdec_get_addr_size() to read reg properties Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 03/15] spi: Add function to allocate a new SPI slave Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 04/15] spi: Use spi_alloc_slave() in each SPI driver Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 05/15] sf: Add spi_flash_alloc() to create a new SPI flash struct Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 06/15] sf: Use spi_flash_alloc() in each SPI flash driver Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 07/15] x86: spi: Add Intel ICH driver Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 08/15] spi: Add parameter for maximum write size Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 09/15] sf: Respect maximum SPI " Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 10/15] x86: spi: Set maximum write size for ICH Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 11/15] sf: Enable FDT-based configuration and memory mapping Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 12/15] x86: Move PCI init before SPI init Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 13/15] x86: Add FDT SPI node for link Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 14/15] x86: Enable SPI flash support for coreboot Simon Glass
2012-12-26 22:28 ` [U-Boot] [PATCH 15/15] x86: Enable time command " Simon Glass
2013-03-08 4:30 ` [U-Boot] [PATCH 0/15] Enhance SPI/SPI flash probing, add support for Intel ICH controller Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DE2F9F.9000706@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox