From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx53loco: Fix PMIC name
Date: Wed, 02 Jan 2013 12:42:16 -0700 [thread overview]
Message-ID: <50E48D98.9020609@boundarydevices.com> (raw)
In-Reply-To: <CAOMZO5CTqq98-7Guysw3PPdbvvbpzKcRBaJcQrLh6gU8f61Epw@mail.gmail.com>
On 1/2/2013 11:33 AM, Fabio Estevam wrote:
> Thanks for bisecting, Robert. Troy/Stefano, Any suggestions about
> this? It would be really nice if we could keep mx53loco functional
> when using gcc 4.6.2. Regards, Fabio Estevam
Could you see if this patch makes any difference? It still needs cleaned
up some before mainline
[PATCH V4 01/11] imximage: mx53 needs transfer length a multiple of 512
diff --git a/tools/imximage.c b/tools/imximage.c
index 63f88b6..7e54e97 100644
--- a/tools/imximage.c
+++ b/tools/imximage.c
@@ -494,6 +494,8 @@ static void imximage_print_header(const void *ptr)
}
}
+#define ALIGN(a, b) (((a) + (b) - 1) & ~((b) - 1))
+
static void imximage_set_header(void *ptr, struct stat *sbuf, int ifd,
struct mkimage_params *params)
{
@@ -515,7 +517,13 @@ static void imximage_set_header(void *ptr, struct stat *sbuf, int ifd,
/* Set the imx header */
(*set_imx_hdr)(imxhdr, dcd_len, params->ep, imxhdr->flash_offset);
- *header_size_ptr = sbuf->st_size + imxhdr->flash_offset;
+ /*
+ * ROM bug alert
+ * mx53 only loads 512 byte multiples.
+ * The remaining fraction of a block bytes would
+ * not be loaded.
+ */
+ *header_size_ptr = ALIGN(sbuf->st_size + imxhdr->flash_offset, 512);
}
int imximage_check_params(struct mkimage_params *params)
-- 1.7.9.5
next prev parent reply other threads:[~2013-01-02 19:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 16:36 [U-Boot] [PATCH] mx53loco: Fix PMIC name Fabio Estevam
2012-12-13 8:25 ` Stefano Babic
2012-12-20 22:04 ` Robert Nelson
2012-12-22 12:51 ` Fabio Estevam
2012-12-26 15:02 ` Fabio Estevam
2012-12-26 15:07 ` Fabio Estevam
2012-12-26 15:21 ` Fabio Estevam
2012-12-26 15:51 ` Robert Nelson
2012-12-26 15:54 ` Fabio Estevam
2012-12-26 16:04 ` Robert Nelson
2012-12-26 16:50 ` Fabio Estevam
2012-12-26 17:08 ` Robert Nelson
2012-12-26 17:21 ` Fabio Estevam
2012-12-26 17:51 ` Robert Nelson
2013-01-02 18:27 ` Robert Nelson
2013-01-02 18:33 ` Fabio Estevam
2013-01-02 19:42 ` Troy Kisky [this message]
2013-01-02 19:58 ` Robert Nelson
2013-01-02 20:02 ` Fabio Estevam
2013-01-03 8:53 ` Stefano Babic
2013-01-03 13:25 ` Fabio Estevam
2013-01-03 13:30 ` Marek Vasut
2013-01-03 13:35 ` Fabio Estevam
2013-01-03 13:49 ` Marek Vasut
2013-01-03 14:07 ` Stefano Babic
2013-01-03 18:18 ` Troy Kisky
2013-01-03 18:26 ` Fabio Estevam
2013-01-03 14:30 ` Fabio Estevam
2013-01-03 14:02 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E48D98.9020609@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox