From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 03 Jan 2013 15:02:30 +0100 Subject: [U-Boot] [PATCH] mx53loco: Fix PMIC name In-Reply-To: References: <1355243818-23962-1-git-send-email-fabio.estevam@freescale.com> <50E48D98.9020609@boundarydevices.com> <50E546FC.7000504@denx.de> Message-ID: <50E58F76.2080505@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/01/2013 14:25, Fabio Estevam wrote: > Hi Stefano, > > On Thu, Jan 3, 2013 at 6:53 AM, Stefano Babic wrote: > >> Hi all, >> >> the patch was only blocked for Wolfgang's comment regarding the >> introduced ALIGN() macro. I think the other doubts regarding issues on >> other Socs (i.e., MX6) can be considered closed as well. IMHO it is >> enough to rename the macro to ROUND_UP (as Troy have already proposed), >> and then I will apply to i.MX tree. > > I tried using DIV_ROUND_UP definition from common.h and the board does not boot. > > I rename it to ROUND, which matches the definition in common.h. I agree with this solution - I do not like that common.h is included, because _config must run and tools should be independent from the selected board. > > Just sent the patch. Then I apply it ! Thanks, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================