From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx53loco: Fix PMIC name
Date: Thu, 03 Jan 2013 11:18:46 -0700 [thread overview]
Message-ID: <50E5CB86.1000201@boundarydevices.com> (raw)
In-Reply-To: <50E590A3.8080309@denx.de>
On 1/3/2013 7:07 AM, Stefano Babic wrote:
> On 03/01/2013 14:49, Marek Vasut wrote:
>> Dear Fabio Estevam,
>>
> Hi,
>
>>> On Thu, Jan 3, 2013 at 11:30 AM, Marek Vasut <marex@denx.de> wrote:
>>>> Ugh, why can't the stuff from common.h be used ?
>>> Yes, I tried it initially, but it throws a lot of errors that I am not
>>> sure that they can be easily fixed:
>> Only with #include <common.h> ?
> I will remark a previous comment - even if including common.h seems a
> good idea to avoid duplications, it makes tools like mkimage to depend
> on the selected board, because <board>_config must run. Even if this is
> not a problem for us u-boot developers, it becomes an issue when these
> tools are included in distros (like u-boot-tools in Ubuntu) and cannot
> be packaged.
>
> Best regards,
> Stefano Babic
>
It would be good to include this in commit log if not already committed.
Thanks
Troy
next prev parent reply other threads:[~2013-01-03 18:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 16:36 [U-Boot] [PATCH] mx53loco: Fix PMIC name Fabio Estevam
2012-12-13 8:25 ` Stefano Babic
2012-12-20 22:04 ` Robert Nelson
2012-12-22 12:51 ` Fabio Estevam
2012-12-26 15:02 ` Fabio Estevam
2012-12-26 15:07 ` Fabio Estevam
2012-12-26 15:21 ` Fabio Estevam
2012-12-26 15:51 ` Robert Nelson
2012-12-26 15:54 ` Fabio Estevam
2012-12-26 16:04 ` Robert Nelson
2012-12-26 16:50 ` Fabio Estevam
2012-12-26 17:08 ` Robert Nelson
2012-12-26 17:21 ` Fabio Estevam
2012-12-26 17:51 ` Robert Nelson
2013-01-02 18:27 ` Robert Nelson
2013-01-02 18:33 ` Fabio Estevam
2013-01-02 19:42 ` Troy Kisky
2013-01-02 19:58 ` Robert Nelson
2013-01-02 20:02 ` Fabio Estevam
2013-01-03 8:53 ` Stefano Babic
2013-01-03 13:25 ` Fabio Estevam
2013-01-03 13:30 ` Marek Vasut
2013-01-03 13:35 ` Fabio Estevam
2013-01-03 13:49 ` Marek Vasut
2013-01-03 14:07 ` Stefano Babic
2013-01-03 18:18 ` Troy Kisky [this message]
2013-01-03 18:26 ` Fabio Estevam
2013-01-03 14:30 ` Fabio Estevam
2013-01-03 14:02 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E5CB86.1000201@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox