From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeroen Hofstee <jeroen@myspectrum.nl>
Date: Sat, 05 Jan 2013 19:16:28 +0100
Subject: [U-Boot] global variables from comon/lcd.c
Message-ID: <50E86DFC.20304@myspectrum.nl>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

While looking at the common/lcd.c I fail to understand why it declares
and uses global variables like lcd_color_fg, lcd_color_color_bg, lcd_base
and relies on the drivers / boards to provide them, leading to code
duplication. It also provides getters / setters for some of these variables.

To me it seems more logical to have these variables in lcd.c itself. This
construction has been around since at least 2004 though, so I tend to
think I am missing something.

Does someone know the reason why these variables are not part
of lcd.c itself?

Regards,
Jeroen