From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeroen Hofstee <jeroen@myspectrum.nl>
Date: Sun, 06 Jan 2013 23:43:19 +0100
Subject: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables
In-Reply-To: <20130105195001.773F320078F@gemini.denx.de>
References: <50E86DFC.20304@myspectrum.nl>
	<1357415148-9243-1-git-send-email-wd@denx.de>
	<20130105195001.773F320078F@gemini.denx.de>
Message-ID: <50E9FE07.3040403@myspectrum.nl>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 01/05/2013 08:50 PM, Wolfgang Denk wrote:
> Dear Anatolij,
>
> In message <1357415148-9243-1-git-send-email-wd@denx.de> you wrote:
>> lcd_color_fg and lcd_color_bg had to be declared in board specific
>> code, but were not actually used there; in addition, we have getter /
>> setter functions for these, which were not used either.
>>
>> Get rid of the global variables, and use the getter function where
>> needed (so far no setter calls are needed).
> A similar change could (and probably should?) be implemented for
> lcd_base, too - but thjis requires a little more code changes, plus
> the introduction of both getter and setter functions.
>
> Do you think this should be done?  If so, I would prepare a patch...
> [Otherwise I'd save the effort...]
yes I think it should be done, unless Anatolij has a really good reason
these variables are defined all over the place.

I have patches ready to remove allot more of these globals. Yet I have
to test them. (and as this is cross arch / several patches this gona take
some time)

Simon: I intend to remove you cursors stuff from tegra since it is not
used anywhere. What is the intention of the cursor stuff?

The amba driver is scheduled for removal as well since it is not used.

Regards,
Jeroen