[U-Boot] [PATCH V4 3/9] DWMMC: Initialise dwmci and resolve EMMC read write issues

Simon Glass
2013-01-11T05:43:12Z

Hi Jaehoon,

On Thu, Jan 10, 2013 at 8:01 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> On 01/11/2013 12:26 AM, Simon Glass wrote:
>> Hi Amar,
>>
>> On Fri, Jan 4, 2013 at 1:34 AM, Amar <amarendra.xt@samsung.com> wrote:
>>> This patch enumerates dwmci and set auto stop command during
>>> dwmci initialisation.
>>> EMMC read/write is not happening in current implementation
>>> due to improper fifo size computation. Hence Modified the fifo size
>>> computation to resolve EMMC read write issues.
>>>
>>> Changes from V1:
>>> 1)Created the macros RX_WMARK_SHIFT and RX_WMARK_MASK in header file.
>>>
>>> Changes from V2:
>>> 1)Updation of commit message and resubmition of proper patch set.
>>>
>>> Changes from V3:
>>> 1)Updated to use the macro DWMCI_CTRL_SEND_AS_CCSD instead of
>>> the hard coded value (1 << 10).
>>
>> I suggest you take a look at patman which might simplify your patch
>> sending and change logs - see tools/patman/README for details.
>>
>>>
>>> Signed-off-by: Amar <amarendra.xt@samsung.com>
>>> ---
>>> drivers/mmc/dw_mmc.c | 14 ++++++++++++--
>>> 1 file changed, 12 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
>>> index 4070d4e..776fdb6 100644
>>> --- a/drivers/mmc/dw_mmc.c
>>> +++ b/drivers/mmc/dw_mmc.c
>>> @@ -136,6 +136,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
>>> return TIMEOUT;
>>> }
>>> timeout--;
>>> + mdelay(1);
>>
>> How long will this delay in total?
> i didn't sure why add the mdelay(1)..i think mdelay(1) is too long.
> Isn't there other approach to resolve read/write issue?

I'm not sure what the root cause is, so I don't know. Perhaps someone
can investigate?

Regards,
Simon

>
> Best Regards,
> Jaehoon Chung
[snip]