public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] fdt: fix dts preprocessor options
@ 2013-01-09  2:07 Allen Martin
  2013-01-09  3:50 ` Stephen Warren
  2013-01-12 17:02 ` Simon Glass
  0 siblings, 2 replies; 3+ messages in thread
From: Allen Martin @ 2013-01-09  2:07 UTC (permalink / raw)
  To: u-boot

Using "-ansi" preprocessor option will cause dts lines that begin with
'#' to choke the preprocessor.  Change to "-x assembler-with-cpp"
instead which is what the kernel uses to preprocess dts files.

Signed-off-by: Allen Martin <amartin@nvidia.com>
---
 dts/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dts/Makefile b/dts/Makefile
index 785104e..922c78c 100644
--- a/dts/Makefile
+++ b/dts/Makefile
@@ -36,7 +36,7 @@ $(error Your architecture does not have device tree support enabled. \
 Please define CONFIG_ARCH_DEVICE_TREE))
 
 # We preprocess the device tree file provide a useful define
-DTS_CPPFLAGS := -ansi \
+DTS_CPPFLAGS := -x assembler-with-cpp \
 		-DARCH_CPU_DTS=\"$(SRCTREE)/arch/$(ARCH)/dts/$(CONFIG_ARCH_DEVICE_TREE).dtsi\" \
 		-DBOARD_DTS=\"$(SRCTREE)/board/$(VENDOR)/$(BOARD)/dts/$(DEVICE_TREE).dts\"
 
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] fdt: fix dts preprocessor options
  2013-01-09  2:07 [U-Boot] [PATCH] fdt: fix dts preprocessor options Allen Martin
@ 2013-01-09  3:50 ` Stephen Warren
  2013-01-12 17:02 ` Simon Glass
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2013-01-09  3:50 UTC (permalink / raw)
  To: u-boot

On 01/08/2013 07:07 PM, Allen Martin wrote:
> Using "-ansi" preprocessor option will cause dts lines that begin with
> '#' to choke the preprocessor.  Change to "-x assembler-with-cpp"
> instead which is what the kernel uses to preprocess dts files.

Well, it's what the kernel hopefully /will/ use if I can ever get the
patch accepted. But anyway, this seems good to me.

Reviewed-by: Stephen Warren <swarren@nvidia.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] fdt: fix dts preprocessor options
  2013-01-09  2:07 [U-Boot] [PATCH] fdt: fix dts preprocessor options Allen Martin
  2013-01-09  3:50 ` Stephen Warren
@ 2013-01-12 17:02 ` Simon Glass
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2013-01-12 17:02 UTC (permalink / raw)
  To: u-boot

On Tue, Jan 8, 2013 at 6:07 PM, Allen Martin <amartin@nvidia.com> wrote:
> Using "-ansi" preprocessor option will cause dts lines that begin with
> '#' to choke the preprocessor.  Change to "-x assembler-with-cpp"
> instead which is what the kernel uses to preprocess dts files.
>
> Signed-off-by: Allen Martin <amartin@nvidia.com>

Acked-by: Simon Glass <sjg@chromium.org>

Thanks for picking this up.

> ---
>  dts/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dts/Makefile b/dts/Makefile
> index 785104e..922c78c 100644
> --- a/dts/Makefile
> +++ b/dts/Makefile
> @@ -36,7 +36,7 @@ $(error Your architecture does not have device tree support enabled. \
>  Please define CONFIG_ARCH_DEVICE_TREE))
>
>  # We preprocess the device tree file provide a useful define
> -DTS_CPPFLAGS := -ansi \
> +DTS_CPPFLAGS := -x assembler-with-cpp \
>                 -DARCH_CPU_DTS=\"$(SRCTREE)/arch/$(ARCH)/dts/$(CONFIG_ARCH_DEVICE_TREE).dtsi\" \
>                 -DBOARD_DTS=\"$(SRCTREE)/board/$(VENDOR)/$(BOARD)/dts/$(DEVICE_TREE).dts\"
>
> --
> 1.7.10.4
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-01-12 17:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-09  2:07 [U-Boot] [PATCH] fdt: fix dts preprocessor options Allen Martin
2013-01-09  3:50 ` Stephen Warren
2013-01-12 17:02 ` Simon Glass

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox