public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v3] mx6qsabresd: Fix booting the kernel from SDHC3
@ 2013-01-10 19:00 Fabio Estevam
  2013-01-13 11:08 ` Stefano Babic
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-01-10 19:00 UTC (permalink / raw)
  To: u-boot

Since commit de7d02aeb (mx6qsabresd: add usdhc2 and usdhc4 support) 
SDHC3 device node is no longer 0, which breaks loading a uImage from SDHC3.

Fix it by adapting the default environment to use CONFIG_SYS_MMC_ENV_DEV as the 
correct mmc node for loading the kernel from.

While at it, go back to using SDHC3 as the default mmc, since we have Yocto 
images that generate an SD card containing U-boot,kernel and rootfs, so it is
more convenient to keep using SDHC3 as it was originally.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v2:
- Use __stringify to properly pass CONFIG_SYS_MMC_ENV_DEV
Changes since v1:
- Properly expand mmcdev macro
- Improve commit log
 include/configs/mx6qsabre_common.h |    2 +-
 include/configs/mx6qsabresd.h      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/configs/mx6qsabre_common.h b/include/configs/mx6qsabre_common.h
index bd2fb10..95ebd98 100644
--- a/include/configs/mx6qsabre_common.h
+++ b/include/configs/mx6qsabre_common.h
@@ -86,7 +86,7 @@
 	"console=" CONFIG_CONSOLE_DEV "\0" \
 	"fdt_high=0xffffffff\0"	  \
 	"initrd_high=0xffffffff\0" \
-	"mmcdev=0\0" \
+	"mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \
 	"mmcpart=1\0" \
 	"mmcroot=" CONFIG_MMCROOT " rootwait rw\0" \
 	"mmcargs=setenv bootargs console=${console},${baudrate} " \
diff --git a/include/configs/mx6qsabresd.h b/include/configs/mx6qsabresd.h
index a1d9285..ccb7751 100644
--- a/include/configs/mx6qsabresd.h
+++ b/include/configs/mx6qsabresd.h
@@ -27,7 +27,7 @@
 
 #define CONFIG_SYS_FSL_USDHC_NUM	3
 #if defined(CONFIG_ENV_IS_IN_MMC)
-#define CONFIG_SYS_MMC_ENV_DEV		2	/* eMMC/uSDHC4 */
+#define CONFIG_SYS_MMC_ENV_DEV		1	/* SDHC3 */
 #define CONFIG_SYS_MMC_ENV_PART		1	/* Boot partition 1 */
 #endif
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH v3] mx6qsabresd: Fix booting the kernel from SDHC3
  2013-01-10 19:00 [U-Boot] [PATCH v3] mx6qsabresd: Fix booting the kernel from SDHC3 Fabio Estevam
@ 2013-01-13 11:08 ` Stefano Babic
  0 siblings, 0 replies; 2+ messages in thread
From: Stefano Babic @ 2013-01-13 11:08 UTC (permalink / raw)
  To: u-boot

On 10/01/2013 20:00, Fabio Estevam wrote:
> Since commit de7d02aeb (mx6qsabresd: add usdhc2 and usdhc4 support) 
> SDHC3 device node is no longer 0, which breaks loading a uImage from SDHC3.
> 
> Fix it by adapting the default environment to use CONFIG_SYS_MMC_ENV_DEV as the 
> correct mmc node for loading the kernel from.
> 
> While at it, go back to using SDHC3 as the default mmc, since we have Yocto 
> images that generate an SD card containing U-boot,kernel and rootfs, so it is
> more convenient to keep using SDHC3 as it was originally.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to -u-boot-imx (fix), thanks.

Best regards,
Stefan Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-01-13 11:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-10 19:00 [U-Boot] [PATCH v3] mx6qsabresd: Fix booting the kernel from SDHC3 Fabio Estevam
2013-01-13 11:08 ` Stefano Babic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox