* [U-Boot] [PATCH] I2C: S3C24X0: Resolve build error for VCMA9
@ 2013-01-14 5:17 Rajeshwari Shinde
2013-01-14 5:24 ` Minkyu Kang
0 siblings, 1 reply; 2+ messages in thread
From: Rajeshwari Shinde @ 2013-01-14 5:17 UTC (permalink / raw)
To: u-boot
This patch resolves the build error for I2C driver in
VCMA9.
Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
---
drivers/i2c/s3c24x0_i2c.c | 4 +++-
drivers/i2c/s3c24x0_i2c.h | 3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c
index 7ec01ec..769a2ba 100644
--- a/drivers/i2c/s3c24x0_i2c.c
+++ b/drivers/i2c/s3c24x0_i2c.c
@@ -67,9 +67,11 @@
* variables to live in SRAM
*/
static unsigned int g_current_bus __attribute__((section(".data")));
+#ifdef CONFIG_OF_CONTROL
+static int i2c_busses __attribute__((section(".data")));
static struct s3c24x0_i2c_bus i2c_bus[CONFIG_MAX_I2C_NUM]
__attribute__((section(".data")));
-static int i2c_busses __attribute__((section(".data")));
+#endif
#if !(defined CONFIG_EXYNOS4 || defined CONFIG_EXYNOS5)
static int GetI2CSDA(void)
diff --git a/drivers/i2c/s3c24x0_i2c.h b/drivers/i2c/s3c24x0_i2c.h
index 1243bf1..c75bcab 100644
--- a/drivers/i2c/s3c24x0_i2c.h
+++ b/drivers/i2c/s3c24x0_i2c.h
@@ -31,11 +31,12 @@ struct s3c24x0_i2c {
u32 iiclc;
};
+#ifdef CONFIG_OF_CONTROL
struct s3c24x0_i2c_bus {
int node; /* device tree node */
int bus_num; /* i2c bus number */
struct s3c24x0_i2c *regs;
enum periph_id id;
};
-
+#endif
#endif /* _S3C24X0_I2C_H */
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [U-Boot] [PATCH] I2C: S3C24X0: Resolve build error for VCMA9
2013-01-14 5:17 [U-Boot] [PATCH] I2C: S3C24X0: Resolve build error for VCMA9 Rajeshwari Shinde
@ 2013-01-14 5:24 ` Minkyu Kang
0 siblings, 0 replies; 2+ messages in thread
From: Minkyu Kang @ 2013-01-14 5:24 UTC (permalink / raw)
To: u-boot
On 14/01/13 14:17, Rajeshwari Shinde wrote:
> This patch resolves the build error for I2C driver in
> VCMA9.
what about errors?
>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
> drivers/i2c/s3c24x0_i2c.c | 4 +++-
> drivers/i2c/s3c24x0_i2c.h | 3 ++-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c
> index 7ec01ec..769a2ba 100644
> --- a/drivers/i2c/s3c24x0_i2c.c
> +++ b/drivers/i2c/s3c24x0_i2c.c
> @@ -67,9 +67,11 @@
> * variables to live in SRAM
> */
> static unsigned int g_current_bus __attribute__((section(".data")));
> +#ifdef CONFIG_OF_CONTROL
> +static int i2c_busses __attribute__((section(".data")));
> static struct s3c24x0_i2c_bus i2c_bus[CONFIG_MAX_I2C_NUM]
> __attribute__((section(".data")));
> -static int i2c_busses __attribute__((section(".data")));
> +#endif
>
> #if !(defined CONFIG_EXYNOS4 || defined CONFIG_EXYNOS5)
> static int GetI2CSDA(void)
> diff --git a/drivers/i2c/s3c24x0_i2c.h b/drivers/i2c/s3c24x0_i2c.h
> index 1243bf1..c75bcab 100644
> --- a/drivers/i2c/s3c24x0_i2c.h
> +++ b/drivers/i2c/s3c24x0_i2c.h
> @@ -31,11 +31,12 @@ struct s3c24x0_i2c {
> u32 iiclc;
> };
>
> +#ifdef CONFIG_OF_CONTROL
> struct s3c24x0_i2c_bus {
> int node; /* device tree node */
> int bus_num; /* i2c bus number */
> struct s3c24x0_i2c *regs;
> enum periph_id id;
I think int is suitable more than enum.
Currently periph_id is exynos specific.
> };
> -
> +#endif
> #endif /* _S3C24X0_I2C_H */
>
Thanks.
Minkyu Kang.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-14 5:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-14 5:17 [U-Boot] [PATCH] I2C: S3C24X0: Resolve build error for VCMA9 Rajeshwari Shinde
2013-01-14 5:24 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox