From mboxrd@z Thu Jan  1 00:00:00 1970
From: Minkyu Kang <mk7.kang@samsung.com>
Date: Mon, 14 Jan 2013 16:39:33 +0900
Subject: [U-Boot] [PATCH 2/4 V2] SMDK5250: Convert lowlevel_init.S to
 lowlevel_init.c
In-Reply-To: <CAPs=JDdiURGbV954-pW9gOWJ9-VC4Zgm7Bc1-MX=ENCkh2y1RQ@mail.gmail.com>
References: <1357564126-13275-1-git-send-email-rajeshwari.s@samsung.com>
	<1357564126-13275-3-git-send-email-rajeshwari.s@samsung.com>
	<50EFC531.9080004@samsung.com>
	<CAPs=JDdiURGbV954-pW9gOWJ9-VC4Zgm7Bc1-MX=ENCkh2y1RQ@mail.gmail.com>
Message-ID: <50F3B635.7080901@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 11/01/13 19:10, Rajeshwari Birje wrote:
> Hi Minkyu Kang,
> 
> Thank you for comments.
> 
> On Fri, Jan 11, 2013 at 1:24 PM, Minkyu Kang <mk7.kang@samsung.com> wrote:
>> Dear Rajeshwari,
>>
>> On 07/01/13 22:08, Rajeshwari Shinde wrote:
>>> This patch converts lowlevel_init.S to lowlevel_init_c.c for
>>> SMDK5250.
>>> Lowlevel.S as of now added only for SMDK5250 and same can be
>>> extended to other SOC in future.
>>>
>>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>>> ---
>>> Changes in V2:
>>>       - Renamed lowlevel_init.S to lowlevel.S and moved to
>>>       arch/arm/cpu/armv7/exynos/
>>>       - Moved power mode defines to power.h
>>>       - Added early serial support.
>>>       - Renamed mem_reset to reset.
>>>  arch/arm/cpu/armv7/exynos/Makefile       |    6 ++
>>>  arch/arm/cpu/armv7/exynos/lowlevel.S     |   35 ++++++++
>>>  arch/arm/include/asm/arch-exynos/power.h |    8 ++
>>>  board/samsung/smdk5250/Makefile          |    2 +-
>>>  board/samsung/smdk5250/dmc_common.c      |    4 +-
>>>  board/samsung/smdk5250/dmc_init_ddr3.c   |    6 +-
>>>  board/samsung/smdk5250/lowlevel_init.S   |   96 --------------------
>>>  board/samsung/smdk5250/lowlevel_init.c   |   81 +++++++++++++++++
>>>  board/samsung/smdk5250/setup.h           |   19 ++++-
>>>  board/samsung/smdk5250/spl_boot.c        |  140 +++++++++++++++++++++++++++--
>>>  spl/Makefile                             |    4 +
>>>  11 files changed, 288 insertions(+), 113 deletions(-)
>>>  create mode 100644 arch/arm/cpu/armv7/exynos/lowlevel.S
>>>  delete mode 100644 board/samsung/smdk5250/lowlevel_init.S
>>>  create mode 100644 board/samsung/smdk5250/lowlevel_init.c
>>>
>>> diff --git a/arch/arm/cpu/armv7/exynos/Makefile b/arch/arm/cpu/armv7/exynos/Makefile
>>> index 9119961..2aa2722 100644
>>> --- a/arch/arm/cpu/armv7/exynos/Makefile
>>> +++ b/arch/arm/cpu/armv7/exynos/Makefile
>>> @@ -22,6 +22,12 @@ include $(TOPDIR)/config.mk
>>>
>>>  LIB  = $(obj)lib$(SOC).o
>>>
>>> +ifdef CONFIG_SMDK5250
>>
>> Is it SMDK5250 specific?
> - Yes, As mentioned in the commit message it is currently been done
> only for SMDK5250 and can be also
> extended to other SOC in Future.
>>

But I think, we don't have to get dependency with the board.

Thanks.
Minkyu Kang.