From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 07/20] env: Add support for callbacks to environment vars
Date: Tue, 15 Jan 2013 07:51:44 +0100 [thread overview]
Message-ID: <50F4FC80.8080407@denx.de> (raw)
In-Reply-To: <CANr=Z=Yy-PcCxDBz5y=UjGkWGVJ_cY8H+7ApNnBBiAGmKDJh8w@mail.gmail.com>
Hi Joe,
On 01/15/2013 12:23 AM, Joe Hershberger wrote:
<snip>
>> Here you see the delay in himport_r() is approx 1 second.
>>
>> And with patch (2598090 [env: Add environment variable flags]) this
>> delay even grows to 2 seconds:
>>
>> [ 3.096149] < 0.004800> U-Boot 2013.01-rc1-00392-g2598090 (Jan 11 2013 - 08:55:45)
>> [ 3.096853] < 0.000704>
>> [ 3.103805] < 0.006952> CPU: AMCC PowerPC 440EPx Rev. A at 528 MHz (PLB=132 OPB=66 EBC=66 PCI=33 MHz)
>> [ 3.106575] < 0.002770> Security/Kasumi support
>> [ 3.112135] < 0.005560> Bootstrap Option H - Boot ROM Location I2C (Addr 0x52)
>> [ 3.117683] < 0.005548> Internal PCI arbiter enabled, PCI async ext clock used
>> [ 3.120548] < 0.002865> 32 kB I-Cache 32 kB D-Cache
>> [ 3.128716] < 0.008168> Board: Sequoia - AMCC PPC440EPx Evaluation Board, Rev. F, PCI-Async=33 MHz
>> [ 3.130099] < 0.001383> I2C: ready
>> [ 3.536470] < 0.406371> DRAM: 256 MiB
>> [ 3.699894] < 0.163424> Flash: 64 MiB
>> [ 3.701553] < 0.001659> NAND: 32 MiB
>>
>> himport_r()
>>
>> [ 5.690365] < 1.988812> PCI: Bus Dev VenId DevId Class Int
>> [ 5.698395] < 0.008030> USB: Host(int phy) Device(ext phy)
>> [ 5.701709] < 0.003314> Net: ppc_4xx_eth0, ppc_4xx_eth1
>>
>>
>> Joe, I didn't dig deeper into these functions and patches. Do you
>> have an idea why these patches introduce this delay? Can you
>> reproduce this on one of your boards? Has anybody else noticed
>> such issues?
>
> That is far more than I would expect. Let me have a look at it.
> Thanks for bringing this up.
Thanks.
> Do you have an extremely large env?
Not really. Here a log of this board:
=> printenv
abc=def
...
yyyy=sdfsdfsfd
Environment size: 4141/8187 bytes
Just let me know if I need to do some more tests to help.
Thanks,
Stefan
next prev parent reply other threads:[~2013-01-15 6:51 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 2:07 [U-Boot] Read-only env variables Joe Hershberger
2010-05-06 21:58 ` Wolfgang Denk
2010-05-10 6:30 ` Joe Hershberger
2010-05-10 6:56 ` Wolfgang Denk
2010-05-10 19:16 ` Joe Hershberger
2010-05-10 20:43 ` Wolfgang Denk
2010-05-10 21:33 ` Joe Hershberger
2010-05-11 20:19 ` Craig Millen
2010-05-11 22:03 ` Wolfgang Denk
2010-05-11 22:52 ` Joe Hershberger
2010-05-12 9:34 ` Wolfgang Denk
2010-05-12 23:46 ` Joe Hershberger
2010-06-22 21:18 ` Wolfgang Denk
2010-06-22 21:49 ` Joe Hershberger
2010-06-22 22:29 ` Wolfgang Denk
2012-08-17 20:49 ` [U-Boot] [PATCH 0/12] Add environment type checking and access control Joe Hershberger
2012-08-17 20:49 ` [U-Boot] [PATCH 01/12] tools/env: Use a board-specific default env Joe Hershberger
2012-08-23 3:17 ` Mike Frysinger
2012-08-23 15:45 ` Joe Hershberger
2012-08-17 20:49 ` [U-Boot] [PATCH 02/12] tools/env: Remove unneeded complexity Joe Hershberger
2012-08-23 3:30 ` Mike Frysinger
2012-08-17 20:49 ` [U-Boot] [PATCH 03/12] tools/env: Don't call env_init() in fw_getenv() Joe Hershberger
2012-08-17 20:49 ` [U-Boot] [PATCH 04/12] tools/env: Reduce the impact on real-time processes Joe Hershberger
2012-08-23 3:30 ` Mike Frysinger
2012-08-23 16:26 ` Joe Hershberger
2012-08-23 20:31 ` Mike Frysinger
2012-08-17 20:49 ` [U-Boot] [PATCH 05/12] tools/env: Serialize calls to fw_*env Joe Hershberger
2012-08-23 3:33 ` Mike Frysinger
2012-10-03 1:12 ` Joe Hershberger
2012-08-17 20:49 ` [U-Boot] [PATCH 06/12] env: Make the "silent" env var take effect immediately Joe Hershberger
2012-08-23 3:35 ` Mike Frysinger
2012-08-17 20:49 ` [U-Boot] [PATCH 07/12] env: Update serial baudrate in env_relocate() Joe Hershberger
2012-08-17 20:49 ` [U-Boot] [PATCH 08/12] env: Check for NULL pointer in envmatch() Joe Hershberger
2012-08-17 23:51 ` Mike Frysinger
2012-08-17 20:49 ` [U-Boot] [PATCH 09/12] env: Clarify the cases for env set Joe Hershberger
2012-08-17 20:49 ` [U-Boot] [PATCH 10/12] env: acl: Add environment variable access control list Joe Hershberger
2012-08-23 3:43 ` Mike Frysinger
2012-09-13 20:13 ` Wolfgang Denk
2012-09-14 2:24 ` Joe Hershberger
2012-09-14 18:42 ` Wolfgang Denk
2012-11-01 16:39 ` [U-Boot] [PATCH v3 0/18] Add environment call-back and flags capability Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 01/18] Make linux kernel string funcs available to tools Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 02/18] env: Refactor do_apply to a flag Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 03/18] env: Consolidate common code in hsearch_r() Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 04/18] env: Refactor apply into change_ok Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 05/18] env: Use getenv_yesno() more generally Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 06/18] env: Hide '.' variables in env print by default Joe Hershberger
2012-11-02 10:44 ` Luka Perkov
2012-11-02 22:23 ` Wolfgang Denk
2012-11-01 16:39 ` [U-Boot] [PATCH v3 07/18] env: Add support for callbacks to environment vars Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 08/18] env: Add a command to view callbacks Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 09/18] env: Add a bootfile env handler Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 10/18] env: Add a baudrate " Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 11/18] env: Add a loadaddr " Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 12/18] env: Add a console " Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 13/18] env: Add a silent " Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 14/18] env: Add environment variable flags Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 15/18] tools/env: Add environment variable flags support Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 16/18] env: Add a command to display details about env flags Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 17/18] env: Add support for access control to .flags Joe Hershberger
2012-11-01 16:39 ` [U-Boot] [PATCH v3 18/18] env: Handle write-once ethaddr and serial# generically Joe Hershberger
2012-11-02 22:40 ` [U-Boot] [PATCH v3 0/18] Add environment call-back and flags capability Wolfgang Denk
2012-11-05 0:15 ` Joe Hershberger
2012-12-01 19:44 ` Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 0/20] " Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 01/20] Make linux kernel string funcs available to tools Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 02/20] env: Refactor do_apply to a flag Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 03/20] env: Consolidate common code in hsearch_r() Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 04/20] env: Refactor apply into change_ok Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 05/20] env: Use getenv_yesno() more generally Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 06/20] env: Hide '.' variables in env print by default Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 07/20] env: Add support for callbacks to environment vars Joe Hershberger
2012-12-05 2:34 ` Graeme Russ
2012-12-05 1:52 ` [U-Boot] [PATCH v4 08/20] env: Add a command to view callbacks Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 09/20] env: Add a bootfile env handler Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 10/20] env: Add a baudrate " Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 11/20] env: Add a loadaddr " Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 12/20] env: Add a console " Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 13/20] env: Add a silent " Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 14/20] env: Add environment variable flags Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 15/20] tools/env: Add environment variable flags support Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 16/20] env: Add a command to display details about env flags Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 17/20] env: Add support for access control to .flags Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 18/20] env: Add setenv force support Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 19/20] env: Implement the env delete command Joe Hershberger
2012-12-05 1:52 ` [U-Boot] [PATCH v4 20/20] env: Handle write-once ethaddr and serial# generically Joe Hershberger
2012-12-11 16:51 ` [U-Boot] [PATCH v4 0/20] Add environment call-back and flags capability Tom Rini
2012-12-12 4:16 ` [U-Boot] [PATCH v5 " Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 01/20] Make linux kernel string funcs available to tools Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 02/20] env: Refactor do_apply to a flag Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 03/20] env: Consolidate common code in hsearch_r() Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 04/20] env: Refactor apply into change_ok Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 05/20] env: Use getenv_yesno() more generally Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 06/20] env: Hide '.' variables in env print by default Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 07/20] env: Add support for callbacks to environment vars Joe Hershberger
2013-01-11 8:06 ` Stefan Roese
2013-01-14 23:23 ` Joe Hershberger
2013-01-15 6:51 ` Stefan Roese [this message]
2012-12-12 4:16 ` [U-Boot] [PATCH v5 08/20] env: Add a command to view callbacks Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 09/20] env: Add a bootfile env handler Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 10/20] env: Add a baudrate " Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 11/20] env: Add a loadaddr " Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 12/20] env: Add a console " Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 13/20] env: Add a silent " Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 14/20] env: Add environment variable flags Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 15/20] tools/env: Add environment variable flags support Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 16/20] env: Add a command to display details about env flags Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 17/20] env: Add support for access control to .flags Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 18/20] env: Add setenv force support Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 19/20] env: Implement the env delete command Joe Hershberger
2012-12-12 4:16 ` [U-Boot] [PATCH v5 20/20] env: Handle write-once ethaddr and serial# generically Joe Hershberger
2012-12-14 16:05 ` [U-Boot] [PATCH v5 0/20] Add environment call-back and flags capability Tom Rini
2012-08-17 20:49 ` [U-Boot] [PATCH 11/12] env: acl: Add support for access control to env ACL Joe Hershberger
2012-08-17 20:49 ` [U-Boot] [PATCH 12/12] env: cosmetic: Consilidate the default env definition Joe Hershberger
2012-08-23 3:44 ` Mike Frysinger
2012-10-03 19:38 ` [U-Boot] [PATCH v2 0/5] Cleanup fw_*env and a few common env Joe Hershberger
2012-10-03 19:38 ` [U-Boot] [PATCH v2 1/5] tools/env: Use a board-specific default env Joe Hershberger
2012-10-03 19:38 ` [U-Boot] [PATCH v2 2/5] tools/env: Remove unneeded complexity Joe Hershberger
2012-10-03 19:38 ` [U-Boot] [PATCH v2 3/5] tools/env: Don't call env_init() in fw_getenv() Joe Hershberger
2012-10-03 19:38 ` [U-Boot] [PATCH v2 4/5] tools/env: Serialize calls to fw_*env Joe Hershberger
2012-10-03 23:24 ` uboot at lukaperkov.net
2012-10-04 18:31 ` [U-Boot] [PATCH] tools: Add a README note about fw_printenv lock file Joe Hershberger
2012-10-03 19:38 ` [U-Boot] [PATCH v2 5/5] env: Check for NULL pointer in envmatch() Joe Hershberger
2012-10-09 17:13 ` [U-Boot] [PATCH v2 0/5] Cleanup fw_*env and a few common env Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F4FC80.8080407@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox