From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Wed, 16 Jan 2013 15:46:32 -0700
Subject: [U-Boot] [PATCH 4/7] Tegra114: Add common CPU (shared) files
In-Reply-To: <1358370848-29469-5-git-send-email-twarren@nvidia.com>
References: <1358370848-29469-1-git-send-email-twarren@nvidia.com>
	<1358370848-29469-5-git-send-email-twarren@nvidia.com>
Message-ID: <50F72DC8.6000305@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 01/16/2013 02:14 PM, Tom Warren wrote:
> These files are used by both SPL and main U-Boot.

> diff --git a/arch/arm/cpu/tegra-common/board.c b/arch/arm/cpu/tegra-common/board.c

> @@ -68,7 +70,7 @@ unsigned int query_sdram_size(void)
>  	case 3:
>  		return 0x40000000;	/* 1GB */
>  	}
> -#else	/* Tegra30 */
> +#elif defined(CONFIG_TEGRA30)
>  	/* bits 31:28 in OdmData are used for RAM size on T30  */
>  	switch ((reg) >> 28) {
>  	case 0:
> @@ -84,6 +86,8 @@ unsigned int query_sdram_size(void)
>  	case 8:
>  		return 0x7ff00000;	/* 2GB - 1MB */
>  	}
> +#else
> +		return 0x7ff00000;	/* 2GB - 1MB */

Indentation looks wrong.

I doubt all Tegra114 systems have 2GB RAM; is there no ODMDATA field
allocated for the RAM size? I know there was some discussion of removing
it from ODMDATA and simply reading a memory controller register, since
the information was duplicated there.

> diff --git a/arch/arm/cpu/tegra114-common/clock.c b/arch/arm/cpu/tegra114-common/clock.c
> diff --git a/arch/arm/cpu/tegra114-common/pinmux.c b/arch/arm/cpu/tegra114-common/pinmux.c

I didn't review those two files.