From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 17 Jan 2013 16:11:35 -0700 Subject: [U-Boot] [PATCH 5/7] Tegra114: Dalmore: Add DT files In-Reply-To: References: <1358370848-29469-1-git-send-email-twarren@nvidia.com> <1358370848-29469-6-git-send-email-twarren@nvidia.com> <50F72DEC.70707@wwwdotorg.org> <50F87A52.4060301@wwwdotorg.org> Message-ID: <50F88527.2020803@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/17/2013 03:58 PM, Tom Warren wrote: > Stephen, > > On Thu, Jan 17, 2013 at 3:25 PM, Stephen Warren wrote: >> On 01/17/2013 10:58 AM, Tom Warren wrote: >>> Stephen, >>> >>> On Wed, Jan 16, 2013 at 3:47 PM, Stephen Warren wrote: >>>> On 01/16/2013 02:14 PM, Tom Warren wrote: >>>>> These are stripped down for bringup, They'll be filled out later >>>>> to match-up with the kernel DT contents, and/or as devices are >>>>> brought up (mmc, usb, spi, etc.). >>>> >>>>> diff --git a/board/nvidia/dts/tegra114-dalmore.dts b/board/nvidia/dts/tegra114-dalmore.dts >>>> >>>>> + memory { >>>>> + device_type = "memory"; >>>>> + reg = <0x80000000 0x40000000>; >>>>> + }; >>>> >>>> Indeed, that says just 1GB... >>>> >>> >>> True, but that's what's in current Cardhu DTS, and Harmony, Seaboard, >>> and Ventana DTS files. Only Whistler has 0x20000000 (512MB). >>> >>> How is this used, and how do we keep it in sync with what's really on >>> the board/in the ODMDATA field? >> >> I don't believe U-Boot uses that property from the DT. Probably the DT >> isn't parsed early enough for it to be useful. But if we add it to the >> .dts file, it may as well be correct even so. Or, perhaps we should just >> remove it from the U-Boot DT since it isn't useful. > > Another candidate for a clean-up pass patchset over all Tegra code. > For now, I'll bump it to 2GB for Dalmore (and Cardhu), since that's > what's on the sample boards. 1GB would be safer for Cardhu; there are certainly very commonly used Cardhu SKUs with only 1GB of RAM. I have one. In fact, I once heard that most Linux-oriented Cardhu were 1GB and the 2GB devices were mostly used for Windows development.