[U-Boot] [RFC PATCH v2 0/5] Initial IPv6 support

Wolfgang Denk
2013-01-18T10:23:01Z

Dear Chris,

In message <1358472932-32083-1-git-send-email-judge.packham@gmail.com> you wrote:
>
> This series so far covers the introduction of a IP6addr_t and
> printing/parsing of addresses. I have a patch for testing these basic
> things which I haven't included in this series yet. Is there a unittest
> facility for u-boot I should be using?

We use the DUTS ([1], [2]) for all kind of test cases (but note that
I don't claim it's easy to get started with it).

[1] http://www.denx.de/wiki/DUTS/DUTSDocs
[2] http://git.denx.de/?p=duts.git

> A few open questions
>
> 1) Presumably the majority of the actual V6 code would be included by a
> config option (CONFIG_IPV6). How far should I take that? Should the
> vsprintf code be conditional?

Yes, please.

> 2) Our current out of tree code parallels net.c and net.h. Should I
> continue this for the final version or integrate it into net.[ch].

This depends - if such integration can be done nicely, i. e. without
too many new #ifdef's, then yes, please.

> 3) rxhand_f currently takes an IPaddr_t. I haven't looked at the usage
> of this yet but to support V6 this may need to be a new union or a void
> *.

What exactly is the question here?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Microsoft Multimedia:
You have nice graphics, sound and animations when the system crashes.