[U-Boot] [PATCH 1/5] omap3: add useful dss defines

Nikita Kiryanov
2013-01-21T07:53:45Z

Hi Jeroen,

On 01/20/2013 11:42 PM, Jeroen Hofstee wrote:
> Hello Nikita,
>
[...]
>> +#define GFXFORMAT_ARGB32 0xC
>> +#define GFXFORMAT_RGBA32 0xD
>> +#define GFXFORMAT_RGBx32 0xE
>> +
>> +/* GFX burst size */
>> +#define GFXBURSTSIZE4 0
>> +#define GFXBURSTSIZE8 1
>> +#define GFXBURSTSIZE16 2
>> +
>> /* Panel Configuration */
>> struct panel_config {
>> u32 timing_h;
> most defines in omap dss use the location in the silicon itself.
> For consistency you might want to shift these values to the
> appropriate place. (or just use 32 mode so you can drop most
> if not all of them)
>

These aren't offsets against a base address. These are input values
for the various sections of the dss registers. For example
the /* GFX burst size */ defines are values for
DISPC_GFX_ATTRIBUTES[7:6].

> Regards,
> Jeroen

--
Regards,
Nikita.