From: Gabor Juhos <juhosg@openwrt.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC 06/10] MIPS: qemu-malta: add PCI support
Date: Tue, 22 Jan 2013 07:03:41 +0100 [thread overview]
Message-ID: <50FE2BBD.7030104@openwrt.org> (raw)
In-Reply-To: <20130121125613.944952005FF@gemini.denx.de>
Dear Wolfgang,
> I dislike that you introduce new I/O accessors here, and additionally
> in a way which is explicitly discouraged in U-Boot.
>
> We don't allow to access device registers through a base address plus
> offset notation; instead, we use C structs to describe the register
> layout.
Sorry, I was not aware of these requirements.
> Also, on real hardware your accessors areprobably lacking sufficient
> memory barriers etc.
The lack of memory barriers should not cause any problems on real hardware.
Although I don't have a Malta board, but the original Linux code also does not
use memory barriers.
> Is there any specific reason for not using the usual standard
> accessors as provided by <asm/io.h> ?
No specific reason. The original Linux code uses custom macros for register
access, and I have converted those into inline functions.
Thank you for the review. I will fix the issues in the next version of the patch.
-Gabor
next prev parent reply other threads:[~2013-01-22 6:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 15:19 [U-Boot] [RFC 00/10] MIPS: initial support for emulated Malta board Gabor Juhos
2013-01-19 15:19 ` [U-Boot] [RFC 01/10] MIPS: qemu-malta: add support for emulated MIPS " Gabor Juhos
2013-01-19 15:19 ` [U-Boot] [RFC 02/10] MIPS: qemu-malta: add reset support Gabor Juhos
2013-01-19 15:19 ` [U-Boot] [RFC 03/10] MIPS: qemu-malta: enable flash support Gabor Juhos
2013-01-19 15:19 ` [U-Boot] [RFC 04/10] MIPS: import gt64120.h header from Linux 3.8-rc3 Gabor Juhos
2013-01-19 15:19 ` [U-Boot] [RFC 05/10] MIPS: qemu-malta: setup GT64120 registers as done by YAMON Gabor Juhos
2013-01-19 15:19 ` [U-Boot] [RFC 06/10] MIPS: qemu-malta: add PCI support Gabor Juhos
2013-01-21 12:56 ` Wolfgang Denk
2013-01-22 6:03 ` Gabor Juhos [this message]
2013-01-19 15:19 ` [U-Boot] [RFC 07/10] net: pcnet: use pci_virt_to_mem to obtain buffer addresses Gabor Juhos
2013-01-19 15:19 ` [U-Boot] [RFC 08/10] MIPS: qemu-malta: bring up ethernet Gabor Juhos
2013-01-19 15:19 ` [U-Boot] [RFC 09/10] MIPS: bootm.c: add YAMON style Linux preparation/jump code Gabor Juhos
2013-01-19 15:19 ` [U-Boot] [RFC 10/10] MIPS: start.S: emulate REVISION register for qemu-malta Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FE2BBD.7030104@openwrt.org \
--to=juhosg@openwrt.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox