From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabor Juhos Date: Tue, 22 Jan 2013 07:03:41 +0100 Subject: [U-Boot] [RFC 06/10] MIPS: qemu-malta: add PCI support In-Reply-To: <20130121125613.944952005FF@gemini.denx.de> References: <1358608777-7270-1-git-send-email-juhosg@openwrt.org> <1358608777-7270-7-git-send-email-juhosg@openwrt.org> <20130121125613.944952005FF@gemini.denx.de> Message-ID: <50FE2BBD.7030104@openwrt.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang, > I dislike that you introduce new I/O accessors here, and additionally > in a way which is explicitly discouraged in U-Boot. > > We don't allow to access device registers through a base address plus > offset notation; instead, we use C structs to describe the register > layout. Sorry, I was not aware of these requirements. > Also, on real hardware your accessors areprobably lacking sufficient > memory barriers etc. The lack of memory barriers should not cause any problems on real hardware. Although I don't have a Malta board, but the original Linux code also does not use memory barriers. > Is there any specific reason for not using the usual standard > accessors as provided by ? No specific reason. The original Linux code uses custom macros for register access, and I have converted those into inline functions. Thank you for the review. I will fix the issues in the next version of the patch. -Gabor