From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v3] Consolidate bool type
Date: Wed, 23 Jan 2013 14:01:49 -0800 [thread overview]
Message-ID: <51005DCD.3010706@freescale.com> (raw)
In-Reply-To: <1358977924.9710.8@snotra>
On 01/23/2013 01:52 PM, Scott Wood wrote:
> On 01/23/2013 03:46:04 PM, York Sun wrote:
>> On 01/23/2013 01:41 PM, York Sun wrote:
>> > 'bool' is defined in random places. This patch consolidates them into a
>> > single header file include/linux/types.h, using stdbool.h.
>> >
>> > All other #define, typedef and enum are removed. They are all
>> consistent with
>> > true = 1, false = 0.
>> >
>> > Signed-off-by: York Sun <yorksun@freescale.com>
>> > ---
>> > Change since v1:
>> > Move 'false' and 'true' to the common header file.
>> >
>> > Change since v2:
>> > Use stdbool.h
>> > Consolidate all TRUE, FALSE, True, False, true, false
>> >
>> > Need help to test on all ARCHs with differnt toolchains as well as
>> USE_PRIVATE_LIBGCC.
>> >
>> >
>> I should put RFC in the subject as I am not able to compile all ARCH
>> myself.
>
> So how do you see this patch becoming non-RFC? I think most people
> don't have every single toolchain. You should at least get a toolchain
> for a couple major architectures such as ARM. Usually RFC is for when
> you know the patch has issues, and don't want it applied yet even if
> nobody else finds fault with it.
>
I know this version has problem. I am hoping more people get involved
and test what they can. I tried the arm toolchain you pointed to me. I
couldn't run MAKEALL for arm.
York
next prev parent reply other threads:[~2013-01-23 22:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 21:41 [U-Boot] [Patch v3] Consolidate bool type York Sun
2013-01-23 21:46 ` York Sun
2013-01-23 21:52 ` Scott Wood
2013-01-23 22:01 ` York Sun [this message]
2013-01-23 22:02 ` Scott Wood
2013-01-23 22:05 ` York Sun
2013-01-23 22:10 ` Allen Martin
2013-01-24 17:34 ` Allen Martin
2013-01-24 17:54 ` York Sun
2013-01-24 18:03 ` York Sun
2013-01-24 18:14 ` Scott Wood
2013-01-24 18:23 ` York Sun
2013-01-24 18:28 ` Allen Martin
2013-01-24 18:49 ` York Sun
2013-01-24 18:25 ` Allen Martin
2013-01-24 18:26 ` Wolfgang Denk
2013-01-23 21:53 ` Scott Wood
2013-01-23 22:04 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51005DCD.3010706@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox