From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v3] Consolidate bool type
Date: Wed, 23 Jan 2013 14:04:08 -0800 [thread overview]
Message-ID: <51005E58.10302@freescale.com> (raw)
In-Reply-To: <1358978033.9710.9@snotra>
On 01/23/2013 01:53 PM, Scott Wood wrote:
> On 01/23/2013 03:41:47 PM, York Sun wrote:
>> diff --git a/drivers/net/npe/include/IxOsalTypes.h
>> b/drivers/net/npe/include/IxOsalTypes.h
>> index a190a70..0168902 100644
>> --- a/drivers/net/npe/include/IxOsalTypes.h
>> +++ b/drivers/net/npe/include/IxOsalTypes.h
>> @@ -107,18 +107,10 @@ typedef volatile INT32 VINT32;
>> */
>> #define IX_OSAL_BILLION (1000000000)
>>
>> -#ifndef TRUE
>> -#define TRUE 1L
>> -#endif
>> -
>> #if TRUE != 1
>> #error TRUE is not defined to 1
>> #endif
>>
>> -#ifndef FALSE
>> -#define FALSE 0L
>> -#endif
>> -
>> #if FALSE != 0
>> #error FALSE is not defined to 0
>> #endif
>
> I imagine at least one of these #error statements will kick in now. All
> of the users of non-standard capitalizations must be fixed (I only see
> the definitions affected by this patch), and tests like these should
> just be dropped.
>
Agreed. Will drop in next version (v5).
York
prev parent reply other threads:[~2013-01-23 22:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 21:41 [U-Boot] [Patch v3] Consolidate bool type York Sun
2013-01-23 21:46 ` York Sun
2013-01-23 21:52 ` Scott Wood
2013-01-23 22:01 ` York Sun
2013-01-23 22:02 ` Scott Wood
2013-01-23 22:05 ` York Sun
2013-01-23 22:10 ` Allen Martin
2013-01-24 17:34 ` Allen Martin
2013-01-24 17:54 ` York Sun
2013-01-24 18:03 ` York Sun
2013-01-24 18:14 ` Scott Wood
2013-01-24 18:23 ` York Sun
2013-01-24 18:28 ` Allen Martin
2013-01-24 18:49 ` York Sun
2013-01-24 18:25 ` Allen Martin
2013-01-24 18:26 ` Wolfgang Denk
2013-01-23 21:53 ` Scott Wood
2013-01-23 22:04 ` York Sun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51005E58.10302@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox