From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Wed, 23 Jan 2013 14:04:08 -0800 Subject: [U-Boot] [Patch v3] Consolidate bool type In-Reply-To: <1358978033.9710.9@snotra> References: <1358977307-17350-1-git-send-email-yorksun@freescale.com> <1358978033.9710.9@snotra> Message-ID: <51005E58.10302@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/23/2013 01:53 PM, Scott Wood wrote: > On 01/23/2013 03:41:47 PM, York Sun wrote: >> diff --git a/drivers/net/npe/include/IxOsalTypes.h >> b/drivers/net/npe/include/IxOsalTypes.h >> index a190a70..0168902 100644 >> --- a/drivers/net/npe/include/IxOsalTypes.h >> +++ b/drivers/net/npe/include/IxOsalTypes.h >> @@ -107,18 +107,10 @@ typedef volatile INT32 VINT32; >> */ >> #define IX_OSAL_BILLION (1000000000) >> >> -#ifndef TRUE >> -#define TRUE 1L >> -#endif >> - >> #if TRUE != 1 >> #error TRUE is not defined to 1 >> #endif >> >> -#ifndef FALSE >> -#define FALSE 0L >> -#endif >> - >> #if FALSE != 0 >> #error FALSE is not defined to 0 >> #endif > > I imagine at least one of these #error statements will kick in now. All > of the users of non-standard capitalizations must be fixed (I only see > the definitions affected by this patch), and tests like these should > just be dropped. > Agreed. Will drop in next version (v5). York