From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v3] Consolidate bool type
Date: Thu, 24 Jan 2013 10:03:49 -0800 [thread overview]
Message-ID: <51017785.9060705@freescale.com> (raw)
In-Reply-To: <5101755E.1050406@freescale.com>
On 01/24/2013 09:54 AM, York Sun wrote:
> On 01/24/2013 09:34 AM, Allen Martin wrote:
>> On Wed, Jan 23, 2013 at 02:05:26PM -0800, York Sun wrote:
>>> On 01/23/2013 02:02 PM, Scott Wood wrote:
>>>> On 01/23/2013 04:01:49 PM, York Sun wrote:
>>>>> On 01/23/2013 01:52 PM, Scott Wood wrote:
>>>>>> On 01/23/2013 03:46:04 PM, York Sun wrote:
>>>>>>> On 01/23/2013 01:41 PM, York Sun wrote:
>>>>>>> I should put RFC in the subject as I am not able to compile all ARCH
>>>>>>> myself.
>>>>>>
>>>>>> So how do you see this patch becoming non-RFC? I think most people
>>>>>> don't have every single toolchain. You should at least get a toolchain
>>>>>> for a couple major architectures such as ARM. Usually RFC is for when
>>>>>> you know the patch has issues, and don't want it applied yet even if
>>>>>> nobody else finds fault with it.
>>>>>>
>>>>>
>>>>> I know this version has problem. I am hoping more people get involved
>>>>> and test what they can. I tried the arm toolchain you pointed to me. I
>>>>> couldn't run MAKEALL for arm.
>>>>
>>>> Even before your patch, using USE_PRIVATE_LIBGCC? How many boards failed?
>>>>
>>> I don't know. Wolfgang brought it. Allen kindly offered help to verify
>>> on tegra which uses USE_PRIVATE_LIBGCC.
>>>
>>
>> Built and tested on tegra, no problems. I'm still seeing a lot of
>> references to TRUE/FALSE even after this patch though:
>>
>> $ git grep -e FALSE -e TRUE | awk 'BEGIN {FS = ":"} {print $1}' | sort | uniq
>>
> Thanks, Allen. A long way to go.
>
I thought I have replaced all #define, enum, typedef. I have left alone
those FALSE, False, false but add define like this
+#include <stdbool.h>
+#define TRUE true
+#define FALSE false
+#define True true
+#define False false
Isn't that enough?
I did miss the #if TRUE != 1 part, as pointed out by Scott. Will fix in
next rev.
York
next prev parent reply other threads:[~2013-01-24 18:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 21:41 [U-Boot] [Patch v3] Consolidate bool type York Sun
2013-01-23 21:46 ` York Sun
2013-01-23 21:52 ` Scott Wood
2013-01-23 22:01 ` York Sun
2013-01-23 22:02 ` Scott Wood
2013-01-23 22:05 ` York Sun
2013-01-23 22:10 ` Allen Martin
2013-01-24 17:34 ` Allen Martin
2013-01-24 17:54 ` York Sun
2013-01-24 18:03 ` York Sun [this message]
2013-01-24 18:14 ` Scott Wood
2013-01-24 18:23 ` York Sun
2013-01-24 18:28 ` Allen Martin
2013-01-24 18:49 ` York Sun
2013-01-24 18:25 ` Allen Martin
2013-01-24 18:26 ` Wolfgang Denk
2013-01-23 21:53 ` Scott Wood
2013-01-23 22:04 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51017785.9060705@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox