From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 28 Jan 2013 06:30:21 +0100 Subject: [U-Boot] [PATCH 4/6] mxs: mmc: Allow overriding default card detect implementation In-Reply-To: <201301241934.50675.marex@denx.de> References: <1358902865-20475-1-git-send-email-marex@denx.de> <51017D0A.6020207@denx.de> <201301241929.59266.marex@denx.de> <201301241934.50675.marex@denx.de> Message-ID: <51060CED.5070605@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 24/01/2013 19:34, Marek Vasut wrote: >> That's also an option ... do you want subsequent patch or respin of the >> series? > > Actually, check how it's distributed: > > $ git grep mxsmmc_initialize board | sed "s at .*/@@" > apx4devkit.c: return mxsmmc_initialize(bis, 0, NULL, NULL); > m28evk.c: return mxsmmc_initialize(bis, 0, m28_mmc_wp, NULL); > mx28evk.c: return mxsmmc_initialize(bis, 0, mx28evk_mmc_wp, NULL); > mx23_olinuxino.c: return mxsmmc_initialize(bis, 0, NULL, mx23_olx_mmc_cd); > sc_sps_1.c: return mxsmmc_initialize(bis, 0, NULL, NULL); > > We have quite a bit of variance there. I wonder if using cpu_mmc_init() is worth > it. I see. Ok, then let's the things as they are. Regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================