public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V1 4/7] lcd: add option for board specific splash screen preparation
Date: Tue, 29 Jan 2013 16:44:48 +0200	[thread overview]
Message-ID: <5107E060.8040203@compulab.co.il> (raw)
In-Reply-To: <20130129134603.C10FB2A08AC@gemini.denx.de>

Hi Wolfgang Denk,

On 01/29/2013 03:46 PM, Wolfgang Denk wrote:
> Dear Nikita Kiryanov,
>
> In message <1359463349-11649-5-git-send-email-nikita@compulab.co.il> you wrote:
>> Currently there is no logical place to put the code that prepares the
>> splash image data. The splash image data should be ready in memory
>> before bmp_display() is called, and after the environment is ready
>> (since lcd.c looks for the splash image in an address specified by
>> the environment variable "splashimage").
>>
>> Our window of opportunity in board_init_r() is therefore: between
>> env_relocate() and bmp_display(), and from the available options
>> only the lcd related functions in drv_lcd_init() seem appropriate
>> for such lcd oriented code.
>>
>> Add the option to prepare the splash image data in lcd_logo() right
>> before it is sent to be displayed.
>>
>> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>
> You should add the video custodian on Cc: for such patches.
>
> [Done here].

Will do...
I did Cc Anatolij when running git send-patch though...
It's possible that it was dropped by mailman (see this discussion:
http://www.mail-archive.com/u-boot at lists.denx.de/msg103585.html)
but he should still get the email.

Anyway, I'll start using the Cc line in the patches as requested..

>
> Best regards,
>
> Wolfgang Denk
>


-- 
Regards,
Nikita.

  reply	other threads:[~2013-01-29 14:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-29 12:42 [U-Boot] [PATCH V2 0/7] Add splash screen for CM-T35 Nikita Kiryanov
2013-01-29 12:42 ` [U-Boot] [PATCH V1 1/7] omap3: add useful dss defines Nikita Kiryanov
2013-01-29 13:55   ` Wolfgang Denk
2013-01-29 14:11     ` Nikita Kiryanov
2013-01-29 12:42 ` [U-Boot] [PATCH V2 2/7] omap3: allow dynamic selection of gfx_format Nikita Kiryanov
2013-01-29 13:52   ` Wolfgang Denk
2013-01-29 14:22     ` Nikita Kiryanov
2013-01-29 12:42 ` [U-Boot] [PATCH V2 3/7] lcd: prevent unaligned memory access when displaying splash screen Nikita Kiryanov
2013-01-29 13:46   ` Wolfgang Denk
2013-01-29 14:34     ` Nikita Kiryanov
2013-01-29 12:42 ` [U-Boot] [PATCH V1 4/7] lcd: add option for board specific splash screen preparation Nikita Kiryanov
2013-01-29 13:46   ` Wolfgang Denk
2013-01-29 14:44     ` Nikita Kiryanov [this message]
2013-01-29 12:42 ` [U-Boot] [PATCH V2 5/7] cm-t35: add support for dvi displays Nikita Kiryanov
2013-01-29 14:00   ` Wolfgang Denk
2013-01-29 15:04     ` Nikita Kiryanov
2013-01-29 12:42 ` [U-Boot] [PATCH V2 6/7] cm-t35: add support for user defined lcd parameters Nikita Kiryanov
2013-01-29 13:48   ` Wolfgang Denk
2013-01-30  8:00     ` Nikita Kiryanov
2013-01-29 12:42 ` [U-Boot] [PATCH V2 7/7] cm-t35: add support for loading splash image from NAND Nikita Kiryanov
2013-01-29 13:50   ` Wolfgang Denk
2013-01-30  8:08     ` Nikita Kiryanov
  -- strict thread matches above, loose matches on Subject: below --
2013-01-31  7:39 [U-Boot] [PATCH V3 0/7] Add splash screen for CM-T35 Nikita Kiryanov
2013-01-31  7:39 ` [U-Boot] [PATCH V1 4/7] lcd: add option for board specific splash screen preparation Nikita Kiryanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5107E060.8040203@compulab.co.il \
    --to=nikita@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox