From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 29 Jan 2013 17:16:50 -0700 Subject: [U-Boot] [PATCH 1/2] Tegra114: fdt: Update DT files with I2C info for T114/Dalmore In-Reply-To: References: <1359487175-21064-1-git-send-email-twarren@nvidia.com> <1359487175-21064-2-git-send-email-twarren@nvidia.com> <51082C70.3040108@wwwdotorg.org> <51083A69.5090108@wwwdotorg.org> Message-ID: <51086672.3050609@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/29/2013 02:57 PM, Tom Warren wrote: > Stephen, > > On Tue, Jan 29, 2013 at 2:08 PM, Stephen Warren wrote: >> On 01/29/2013 01:40 PM, Tom Warren wrote: >>> Stephen, >>> >>> On Tue, Jan 29, 2013 at 1:09 PM, Stephen Warren wrote: >>>> On 01/29/2013 12:19 PM, Tom Warren wrote: >>>>> Note that T114 does not have a separate/different DVC (power I2C) >>>>> controller like T20 - all 5 I2C controllers are identical, but >>>>> I2C5 is used to designate the controller intended for power >>>>> control (PWR_I2C in the schematics). >>>>> + reg = <0x7000c000 0x100>; >>>> >>>> The interrupts property is missing here. >>> >>> I didn't have an interrupts property for I2C on the T30 dts files, >>> either. >> >> That sounds like a bug in the DT. >> >>> What is it used for in U-Boot? >> >> U-Boot doesn't use interrupts at least on Tegra, so it's not used. >> However, it'd be best to keep the U-Boot DT in line with the kernel DT >> so we can easily spot differences. There has been talk of trying to use >> the same DT for both too, although we're a long long way off from that. > > I'll add it, but it seems silly to add unused values, especially when > your past review critiques of DT files have asked for minimum > functionality, which I agree with. I meant to mention here that my previous comments were about unused nodes; it doesn't seem useful to add a bunch of nodes that we aren't using, until the drivers are ready and we actually end up using those nodes. However, when a node is added, we should fill it in fully, so the DT conforms to the binding for that node.