From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Kiryanov Date: Wed, 30 Jan 2013 10:00:53 +0200 Subject: [U-Boot] [PATCH V2 6/7] cm-t35: add support for user defined lcd parameters In-Reply-To: <20130129134854.35B182A099E@gemini.denx.de> References: <1359463349-11649-1-git-send-email-nikita@compulab.co.il> <1359463349-11649-7-git-send-email-nikita@compulab.co.il> <20130129134854.35B182A099E@gemini.denx.de> Message-ID: <5108D335.4080106@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang Denk, On 01/29/2013 03:48 PM, Wolfgang Denk wrote: > Dear Nikita Kiryanov, > > In message <1359463349-11649-7-git-send-email-nikita@compulab.co.il> you wrote: >> Add support for user defined lcd parameters for cm-t35 splash screen. > > Why do you implement another custom method to configure the display? > This has been done before, and we should reuse existing methods. > This patch implements a user interface, not reimplements methods that configure the DSS. For that, I'm still using omap3_dss_panel_config(), struct panel_config, and omap3_dss.h #defines. > Best regards, > > Wolfgang Denk > -- Regards, Nikita.