From mboxrd@z Thu Jan 1 00:00:00 1970 From: R Sricharan Date: Fri, 1 Feb 2013 12:17:15 +0530 Subject: [U-Boot] [PATCH 2/7] ARM: OMAP4+: Change the PRCM structure prototype common for all Socs In-Reply-To: <510A9E73.4040800@ti.com> References: <1359611525-19017-1-git-send-email-r.sricharan@ti.com> <1359611525-19017-3-git-send-email-r.sricharan@ti.com> <510A9E73.4040800@ti.com> Message-ID: <510B64F3.8010602@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 31 January 2013 10:10 PM, Tom Rini wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 01/31/2013 12:52 AM, R Sricharan wrote: >> The current PRCM structure prototype directly matches the hardware >> register layout. So there is a need to change this for every new >> silicon revision which has register space changes. >> >> Avoiding this by making the prototye generic and populating the >> register addresses seperately for all Socs. >> >> Signed-off-by: R Sricharan > [snip] >> arch/arm/cpu/armv7/omap4/prcm-regs.c | 267 ++++++++++++ >> arch/arm/cpu/armv7/omap5/prcm-regs.c | 278 >> +++++++++++++ > > These two are missing license information, please fix. > Sorry for missing this. Will send a V2 > Otherwise, I like the concept and I think it all looks fine. We stay > about the same, binary size wise with all of this, correct? > Yes,i checked this after the change.The spl size for OMAP4 is still 29KB and less than the limit (32KB). The size is never an issue with OMAP5 Regards, Sricharan