From mboxrd@z Thu Jan 1 00:00:00 1970 From: R Sricharan Date: Fri, 1 Feb 2013 12:19:01 +0530 Subject: [U-Boot] [PATCH 4/7] ARM: OMAP4+: Clean up the pmic code In-Reply-To: <20130131170138.GA30932@bill-the-cat> References: <1359611525-19017-1-git-send-email-r.sricharan@ti.com> <1359611525-19017-5-git-send-email-r.sricharan@ti.com> <20130131170138.GA30932@bill-the-cat> Message-ID: <510B655D.4070300@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On Thursday 31 January 2013 10:31 PM, Tom Rini wrote: > On Thu, Jan 31, 2013 at 11:22:02AM +0530, R Sricharan wrote: > >> The pmic code is duplicated for OMAP 4 and 5. >> Instead move the data to Soc specific place and >> share the code. >> >> Signed-off-by: R Sricharan > [snip] >> +++ b/arch/arm/cpu/armv7/omap4/hw_data.c > [snip] >> +struct vcores_data omap4430_volts_es1 = { >> + .mpu.value = 1325, .mpu.addr = SMPS_REG_ADDR_VCORE1, >> + .mpu.pmic = &twl6030_4430es1, > > Here and in omap5/hw_data.c, split these up into multiple lines. > Thanks for reviewing all. Will correct this and send a consolidated V2. Regards, Sricharan