From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabor Juhos Date: Sat, 02 Feb 2013 01:44:44 +0100 Subject: [U-Boot] [PATCH v2] MIPS: start.S: unify and simplify reset vector handling In-Reply-To: References: <1359591991-15156-1-git-send-email-daniel.schwierzeck@gmail.com> <1359752134-9547-1-git-send-email-daniel.schwierzeck@gmail.com> <510C3F09.8030607@openwrt.org> Message-ID: <510C617C.4010509@openwrt.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de 2013.02.01. 23:48 keltez?ssel, Daniel Schwierzeck ?rta: >>> + /* U-boot entry point */ >>> + b reset >>> + nop >>> + >>> + .org 0x10 >>> #ifdef CONFIG_SYS_XWAY_EBU_BOOTCFG >> >> The .org should be within the ifdef. Although it does not change the generated >> binary code, but logically it would be a more correct place. Sorry, I should >> have mentioned that in the previous mail. >> >> -Gabor >> >> > > I think we should keep it outside. If we add qemu-malta, then we get > another #if branch. Ok, it does not really matter now. The .org can be moved into the ifdef later when there will be a board which needs some other magic value at 0x14 for example. > I also would like to move some register inits (watch, timer, status) > to slightly reduce > binary size. Hm, do you want to initialize those registers between the reserved vectors? -Gabor