From: Gabor Juhos <juhosg@openwrt.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 01/10] MIPS: qemu-malta: add support for emulated MIPS Malta board
Date: Sun, 03 Feb 2013 08:19:36 +0100 [thread overview]
Message-ID: <510E0F88.40005@openwrt.org> (raw)
In-Reply-To: <CACUy__X9J=r663Y66=J4M+R=Mq1MnqRREqXeYdEfXdF4ZqLbBA@mail.gmail.com>
Hi Daniel,
...
>> diff --git a/board/qemu-malta/lowlevel_init.S b/board/qemu-malta/lowlevel_init.S
>> new file mode 100644
>> index 0000000..c5c5bd9
>> --- /dev/null
>> +++ b/board/qemu-malta/lowlevel_init.S
>> @@ -0,0 +1,19 @@
>> +/*
>> + * Copyright (C) 2013 Gabor Juhos <juhosg@openwrt.org>
>> + *
>> + * This program is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU General Public License version 2 as published
>> + * by the Free Software Foundation.
>> + */
>> +
>> +#include <asm/regdef.h>
>> +
>> + .text
>> + .set noreorder
>> + .set mips32
>> +
>> + .globl lowlevel_init
>> +lowlevel_init:
>> +
>> + jr ra
>> + nop
>
> can't we use CONFIG_SKIP_LOWLEVEL_INIT and drop this file?
> We neither need to initialize a memory controller nor caches on Qemu.
We can use that option and drop the file from this patch. However in that case I
will have to reintroduce it and remove the config option in a subsequent patch.
The lowlevel_init will be used to initialize the Galileo system controller.
...
>> diff --git a/include/configs/qemu-malta.h b/include/configs/qemu-malta.h
>> new file mode 100644
>> index 0000000..c72c5dd
>> --- /dev/null
>> +++ b/include/configs/qemu-malta.h
>> @@ -0,0 +1,104 @@
>> +/*
>> + * Copyright (C) 2013 Gabor Juhos <juhosg@openwrt.org>
>> + *
>> + * This program is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU General Public License version 2 as published
>> + * by the Free Software Foundation.
>> + */
>> +
>> +#ifndef _QEMU_MALTA_CONFIG_H
>> +#define _QEMU_MALTA_CONFIG_H
>> +
>> +#include <asm/addrspace.h>
>> +#include <asm/malta.h>
>> +
>> +/*
>> + * System configuration
>> + */
>> +#define CONFIG_QEMU_MALTA
>
> we should extend qemu-mips.h and define CONFIG_QEMU_MALTA
> respectively CONFIG_QEMU_MALTA in boards.cfg to avoid redundant code.
> All differences could be handled with these options.
Sure, we can do it if you prefer that. In my opinion it is much cleaner to
introduce a new config file, instead of adding random ifdef statements into
another file.
-Gabor
next prev parent reply other threads:[~2013-02-03 7:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 16:05 [U-Boot] [PATCH v2 00/10] MIPS: initial support for emulated Malta board Gabor Juhos
2013-02-02 16:05 ` [U-Boot] [PATCH v2 01/10] MIPS: qemu-malta: add support for emulated MIPS " Gabor Juhos
2013-02-02 19:34 ` Daniel Schwierzeck
2013-02-03 7:19 ` Gabor Juhos [this message]
2013-02-02 16:05 ` [U-Boot] [PATCH v2 02/10] MIPS: qemu-malta: add reset support Gabor Juhos
2013-02-02 19:35 ` Daniel Schwierzeck
2013-02-03 8:02 ` Gabor Juhos
2013-02-02 16:05 ` [U-Boot] [PATCH v2 03/10] MIPS: qemu-malta: enable flash support Gabor Juhos
2013-02-02 16:06 ` [U-Boot] [PATCH v2 04/10] MIPS: import gt64120.h header from Linux 3.8-rc3 Gabor Juhos
2013-02-02 16:06 ` [U-Boot] [PATCH v2 05/10] MIPS: qemu-malta: setup GT64120 registers as done by YAMON Gabor Juhos
2013-02-02 19:39 ` Daniel Schwierzeck
2013-02-03 8:15 ` Gabor Juhos
2013-02-02 16:06 ` [U-Boot] [PATCH v2 06/10] MIPS: qemu-malta: add PCI support Gabor Juhos
2013-02-02 19:37 ` Daniel Schwierzeck
2013-02-03 8:25 ` Gabor Juhos
2013-02-02 16:06 ` [U-Boot] [PATCH v2 07/10] net: pcnet: use pci_virt_to_mem to obtain buffer addresses Gabor Juhos
2013-02-02 19:42 ` Daniel Schwierzeck
2013-02-05 1:29 ` Nobuhiro Iwamatsu
2013-02-02 16:06 ` [U-Boot] [PATCH v2 08/10] MIPS: qemu-malta: bring up ethernet Gabor Juhos
2013-02-02 16:06 ` [U-Boot] [PATCH v2 09/10] MIPS: bootm.c: add YAMON style Linux preparation/jump code Gabor Juhos
2013-02-02 16:06 ` [U-Boot] [PATCH v2 10/10] MIPS: start.S: emulate REVISION register for qemu-malta Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510E0F88.40005@openwrt.org \
--to=juhosg@openwrt.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox