From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeroen Hofstee Date: Mon, 04 Feb 2013 22:02:13 +0100 Subject: [U-Boot] [PATCH 0/5] Create an API for safely accessing BMP header fields In-Reply-To: <20130204203502.CE087200113@gemini.denx.de> References: <1359977979-28585-1-git-send-email-nikita@compulab.co.il> <20130204125734.228623e8@lilith> <510FAB72.3050901@compulab.co.il> <20130204203502.CE087200113@gemini.denx.de> Message-ID: <511021D5.80301@myspectrum.nl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, On 02/04/2013 09:35 PM, Wolfgang Denk wrote: > Dear Nikita Kiryanov, > > In message <510FAB72.3050901@compulab.co.il> you wrote: >> I did mention that I consider that fix as temporary. I believe this fix >> is better because it addresses the issue everywhere and does so in a >> more maintainable way (does not require the address fix to be duplicated >> everywhere there is a problem). > Can you please explain (again) what exactly you consider the problem? > > That I can load a BMP image to anodd address, and that this will > result in odd results? > If you use eldk 5.3, a board will be bricked if you set the load address to not (an aligned address _+ 2_). So anyone who didn't know the +2 requirement, has a bricked board (and can't recover). So this is really a different then md trapping, since resetting the board won't help... it is broken / kaput. That said, I am not really in favor of this solution. But I do think it needs to be fixed. Regards, Jeroen