From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Fri, 08 Feb 2013 12:12:48 -0700 Subject: [U-Boot] [PATCH v5 23/23] tegra: Enable generic board for Seaboard. In-Reply-To: References: <1360336339-10703-1-git-send-email-sjg@chromium.org> <1360336339-10703-24-git-send-email-sjg@chromium.org> <51153489.5090908@wwwdotorg.org> Message-ID: <51154E30.7060301@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/08/2013 11:10 AM, Simon Glass wrote: > Hi Stephen > > On Fri, Feb 8, 2013 at 9:23 AM, Stephen Warren wrote: >> On 02/08/2013 08:12 AM, Simon Glass wrote: >>> Enable CONFIG_SYS_GENERIC_BOARD for Tegra 2 Seaboard. >> >> Shouldn't this be enabled for Tegra generically, rather than for just >> one Tegra board? I haven't looked at the rest of the series yet, but it >> sure seems better if all Tegra boards always work the same way. > > Yes but I can only test on that board. I suspect it should be OK with > others but I've taken a fairly conservative approach as I don't want > to break things. > > If you have a board about, please try putting it in tegra-common.h or > similar and see what happens. This is something Tom should drive. > BTW it would be nice to have a tegra20-dt.h config. Then I would just > test that one board and know that other changes can only be > FDT-related. But I think due to pinmux that isn't possible right now, > as previously discussed. Well, there are quite a few peripherals which are only initialized/instantiated from board files too, so a generic DT config wouldn't be very useful yet, although Tom and Allen are in the process of converting things as they add Tegra114 support.