[U-Boot] [PATCH] mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

Lukasz Majewski
2013-02-22T07:11:01Z

Hi Tom,

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 02/21/2013 06:33 PM, Jaehoon Chung wrote:
> > Hi Tom,
> >
> > On 02/22/2013 02:45 AM, Tom Rini wrote: On 02/21/2013 12:21 PM,
> > Lukasz Majewski wrote:
> >>>> Dear All,
> >>>>
> >>>> I'd like to kindly ask for any feedback on this patch.
> >>>>
> >>>> It is now more than month on the u-boot mailing list...
> >
> > OK, sorry, the generic name of the driver threw me for a minute.
> > I'm fine with this change going up u-boot-samsung -> u-boot-arm ->
> > master since it's a samsung-only driver right now. Does this work
> > for you?
> >> I think that this driver didn't use samsung-only. going up
> >> u-boot-samsung? I'm not sure that.
>
> Unless the context got very wrong, it touches drivers/mmc/sdhci.c
> which is controlled by CONFIG_SDHCI which is only turned on in what
> look like samsung platforms to me.
>

There is a /asm/arch-pantheon/config.h file which sets the CONFIG_SDHCI
flag. It was added by Lei Wen (who is CC'ed to this thread) and looks
like ARM926EJS (Marwell Semiconductor) processor based system.

Other systems are indeed samsung based processors.

I don't mind if this patch would go via u-boot-samsung tree.

Moreover, since this change "touches" Lei system, I think that he should
have expressed his opinion. Sadly this didn't happened....

>
> - --
> Tom
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJRJrESAAoJENk4IS6UOR1WKeYP/2FBhDgWjyf5Sh8m0Q1bdhRm
> EvNMWLuexHUbxOu0AMsKyurPAGHnkfsWtNBnQXe804XXY29chFTsLlJUh4EGUBHm
> KiSJPU9LAlDt/aMmv6ncFcgJ9I7jyu8bETBLbJszDSleO0DqpUBu+R7isVv0N7n3
> Uozo89zHpCvGrN2VLlQetMrTTJKquThn4CT9SIm02Z2OM5l3vBLUg+QMk1MCjDUd
> znIsFtUG5F+8T0uqzFN698RYACagPl5Y10HMylWHZgpgV2wGxQWrXspx78wHRSvy
> cwDPd2SVQbO3o3s9ixlppxeO2kpva8NouzsCJn4nH5ivrHumFCm8SI2ka4YE6du5
> 2b6Hol1Ie9jxq8B6cCNdEsHeHru3r+r19GzTNE0VfbrArpM8jO7FHcLruyzRjlaC
> QyzDgdLXzV21113U+UlyAk5yWZ4he4xVHV4oFoN+QhIbQdNZP3gWkzLUQLLr9ry6
> iIgeLx8GDONVxv7hGfNvAaxhQMgvANUOEtPP0CV+K0b60IDXyrFyP1xt5NRN77iR
> v1rfcqitudFUyF6zqbDDLC2a5EW45UVyQR0WdZK999TWHS/U+5pTcDHhls1F16VD
> wGZ+k+RmJQVWVdLImOsyWewPeZtzt02qlNom9LF8sKq8T4Uyf8uLhKksOyfxMCR7
> AvZ53JHQoAAvhgPVn4KF
> =7Oz4
> -----END PGP SIGNATURE-----

--
Best regards,

Lukasz Majewski

Samsung R&D Poland (SRPOL) | Linux Platform Group