* [U-Boot] [PATCH 1/3] mx23evk: Remove unneeded 'undef's
@ 2013-01-28 11:40 Fabio Estevam
2013-01-28 11:41 ` [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Fabio Estevam @ 2013-01-28 11:40 UTC (permalink / raw)
To: u-boot
Rather than 'undef'ing some symbols, just remove them instead.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/configs/mx23evk.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h
index c44a8b8..51aa9c4 100644
--- a/include/configs/mx23evk.h
+++ b/include/configs/mx23evk.h
@@ -49,8 +49,6 @@
/* U-Boot Commands */
#include <config_cmd_default.h>
-#undef CONFIG_CMD_NET
-#undef CONFIG_CMD_NFS
#define CONFIG_DISPLAY_CPUINFO
#define CONFIG_DOS_PARTITION
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE
2013-01-28 11:40 [U-Boot] [PATCH 1/3] mx23evk: Remove unneeded 'undef's Fabio Estevam
@ 2013-01-28 11:41 ` Fabio Estevam
2013-01-28 12:00 ` Otavio Salvador
` (2 more replies)
2013-01-28 11:41 ` [U-Boot] [PATCH 3/3] mx23evk: Turn on caches Fabio Estevam
2013-01-28 11:58 ` [U-Boot] [PATCH 1/3] mx23evk: Remove unneeded 'undef's Otavio Salvador
2 siblings, 3 replies; 12+ messages in thread
From: Fabio Estevam @ 2013-01-28 11:41 UTC (permalink / raw)
To: u-boot
The baudrate is already defined by CONFIG_BAUDRATE and there is no need
to keep CONFIG_SYS_BAUDRATE_TABLE.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/configs/mx23evk.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h
index 51aa9c4..e43b93f 100644
--- a/include/configs/mx23evk.h
+++ b/include/configs/mx23evk.h
@@ -110,7 +110,6 @@
#define CONFIG_PL01x_PORTS { (void *)MXS_UARTDBG_BASE }
#define CONFIG_CONS_INDEX 0
#define CONFIG_BAUDRATE 115200 /* Default baud rate */
-#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
/* DMA */
#define CONFIG_APBH_DMA
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH 3/3] mx23evk: Turn on caches
2013-01-28 11:40 [U-Boot] [PATCH 1/3] mx23evk: Remove unneeded 'undef's Fabio Estevam
2013-01-28 11:41 ` [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE Fabio Estevam
@ 2013-01-28 11:41 ` Fabio Estevam
2013-01-28 12:47 ` Marek Vasut
2013-02-12 17:51 ` Stefano Babic
2013-01-28 11:58 ` [U-Boot] [PATCH 1/3] mx23evk: Remove unneeded 'undef's Otavio Salvador
2 siblings, 2 replies; 12+ messages in thread
From: Fabio Estevam @ 2013-01-28 11:41 UTC (permalink / raw)
To: u-boot
It is safe to turn on data and instruction caches for mx23.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/configs/mx23evk.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h
index e43b93f..ae8cf6c 100644
--- a/include/configs/mx23evk.h
+++ b/include/configs/mx23evk.h
@@ -33,8 +33,6 @@
#define CONFIG_MACH_TYPE MACH_TYPE_MX23EVK
#define CONFIG_SYS_NO_FLASH
-#define CONFIG_SYS_ICACHE_OFF
-#define CONFIG_SYS_DCACHE_OFF
#define CONFIG_BOARD_EARLY_INIT_F
#define CONFIG_ARCH_MISC_INIT
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH 1/3] mx23evk: Remove unneeded 'undef's
2013-01-28 11:40 [U-Boot] [PATCH 1/3] mx23evk: Remove unneeded 'undef's Fabio Estevam
2013-01-28 11:41 ` [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE Fabio Estevam
2013-01-28 11:41 ` [U-Boot] [PATCH 3/3] mx23evk: Turn on caches Fabio Estevam
@ 2013-01-28 11:58 ` Otavio Salvador
2 siblings, 0 replies; 12+ messages in thread
From: Otavio Salvador @ 2013-01-28 11:58 UTC (permalink / raw)
To: u-boot
On Mon, Jan 28, 2013 at 9:40 AM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> Rather than 'undef'ing some symbols, just remove them instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/configs/mx23evk.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h
> index c44a8b8..51aa9c4 100644
> --- a/include/configs/mx23evk.h
> +++ b/include/configs/mx23evk.h
> @@ -49,8 +49,6 @@
>
> /* U-Boot Commands */
> #include <config_cmd_default.h>
> -#undef CONFIG_CMD_NET
> -#undef CONFIG_CMD_NFS
>
> #define CONFIG_DISPLAY_CPUINFO
> #define CONFIG_DOS_PARTITION
The problem is that the default cmd set include them; that's why I had
the undef.
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE
2013-01-28 11:41 ` [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE Fabio Estevam
@ 2013-01-28 12:00 ` Otavio Salvador
2013-01-28 12:46 ` Marek Vasut
2013-02-12 17:51 ` Stefano Babic
2 siblings, 0 replies; 12+ messages in thread
From: Otavio Salvador @ 2013-01-28 12:00 UTC (permalink / raw)
To: u-boot
On Mon, Jan 28, 2013 at 9:41 AM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> The baudrate is already defined by CONFIG_BAUDRATE and there is no need
> to keep CONFIG_SYS_BAUDRATE_TABLE.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Otavio Salvador <otavio@ossystems.com.br>
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE
2013-01-28 11:41 ` [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE Fabio Estevam
2013-01-28 12:00 ` Otavio Salvador
@ 2013-01-28 12:46 ` Marek Vasut
2013-01-28 12:53 ` Fabio Estevam
2013-02-12 17:51 ` Stefano Babic
2 siblings, 1 reply; 12+ messages in thread
From: Marek Vasut @ 2013-01-28 12:46 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> The baudrate is already defined by CONFIG_BAUDRATE and there is no need
> to keep CONFIG_SYS_BAUDRATE_TABLE.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/configs/mx23evk.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h
> index 51aa9c4..e43b93f 100644
> --- a/include/configs/mx23evk.h
> +++ b/include/configs/mx23evk.h
> @@ -110,7 +110,6 @@
> #define CONFIG_PL01x_PORTS { (void *)MXS_UARTDBG_BASE }
> #define CONFIG_CONS_INDEX 0
> #define CONFIG_BAUDRATE 115200 /* Default baud rate */
> -#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
This will not allow different baudrates now, will it?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH 3/3] mx23evk: Turn on caches
2013-01-28 11:41 ` [U-Boot] [PATCH 3/3] mx23evk: Turn on caches Fabio Estevam
@ 2013-01-28 12:47 ` Marek Vasut
2013-01-28 12:51 ` Fabio Estevam
2013-02-12 17:51 ` Stefano Babic
1 sibling, 1 reply; 12+ messages in thread
From: Marek Vasut @ 2013-01-28 12:47 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> It is safe to turn on data and instruction caches for mx23.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/configs/mx23evk.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h
> index e43b93f..ae8cf6c 100644
> --- a/include/configs/mx23evk.h
> +++ b/include/configs/mx23evk.h
> @@ -33,8 +33,6 @@
> #define CONFIG_MACH_TYPE MACH_TYPE_MX23EVK
>
> #define CONFIG_SYS_NO_FLASH
> -#define CONFIG_SYS_ICACHE_OFF
> -#define CONFIG_SYS_DCACHE_OFF
> #define CONFIG_BOARD_EARLY_INIT_F
> #define CONFIG_ARCH_MISC_INIT
Can you fix this for olinuxino (if not done already) too please?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH 3/3] mx23evk: Turn on caches
2013-01-28 12:47 ` Marek Vasut
@ 2013-01-28 12:51 ` Fabio Estevam
0 siblings, 0 replies; 12+ messages in thread
From: Fabio Estevam @ 2013-01-28 12:51 UTC (permalink / raw)
To: u-boot
On Mon, Jan 28, 2013 at 10:47 AM, Marek Vasut <marex@denx.de> wrote:
> Can you fix this for olinuxino (if not done already) too please?
mx23olinuxino has the caches turned on already.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE
2013-01-28 12:46 ` Marek Vasut
@ 2013-01-28 12:53 ` Fabio Estevam
2013-01-28 13:10 ` Marek Vasut
0 siblings, 1 reply; 12+ messages in thread
From: Fabio Estevam @ 2013-01-28 12:53 UTC (permalink / raw)
To: u-boot
On Mon, Jan 28, 2013 at 10:46 AM, Marek Vasut <marex@denx.de> wrote:
> This will not allow different baudrates now, will it?
You still may change the baudrate if you need to.
CONFIG_SYS_BAUDRATE_TABLE has been placed to a common place after the
commit below:
commit 26750c8aee2383a026e0cf89e9310628d3a5a6a0
Author: Tom Rini <trini@ti.com>
Date: Tue Jun 19 12:54:34 2012 +0000
CONFIG_SYS_BAUDRATE_TABLE: Add <config_fallbacks.h>, place there
We provide a default table of { 9600, 19200, 38400, 57600, 115200 }
in <config_fallbacks.h> which mkconfig places after <configs/...h> in
the generated config file. This is used when a board has not set its
own table.
Signed-off-by: Tom Rini <trini@ti.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE
2013-01-28 12:53 ` Fabio Estevam
@ 2013-01-28 13:10 ` Marek Vasut
0 siblings, 0 replies; 12+ messages in thread
From: Marek Vasut @ 2013-01-28 13:10 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> On Mon, Jan 28, 2013 at 10:46 AM, Marek Vasut <marex@denx.de> wrote:
> > This will not allow different baudrates now, will it?
>
> You still may change the baudrate if you need to.
>
> CONFIG_SYS_BAUDRATE_TABLE has been placed to a common place after the
> commit below:
>
> commit 26750c8aee2383a026e0cf89e9310628d3a5a6a0
> Author: Tom Rini <trini@ti.com>
> Date: Tue Jun 19 12:54:34 2012 +0000
>
> CONFIG_SYS_BAUDRATE_TABLE: Add <config_fallbacks.h>, place there
>
> We provide a default table of { 9600, 19200, 38400, 57600, 115200 }
> in <config_fallbacks.h> which mkconfig places after <configs/...h> in
> the generated config file. This is used when a board has not set its
> own table.
>
> Signed-off-by: Tom Rini <trini@ti.com>
Ok then I'd say -- kill 'em all!!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH 3/3] mx23evk: Turn on caches
2013-01-28 11:41 ` [U-Boot] [PATCH 3/3] mx23evk: Turn on caches Fabio Estevam
2013-01-28 12:47 ` Marek Vasut
@ 2013-02-12 17:51 ` Stefano Babic
1 sibling, 0 replies; 12+ messages in thread
From: Stefano Babic @ 2013-02-12 17:51 UTC (permalink / raw)
To: u-boot
On 28/01/2013 12:41, Fabio Estevam wrote:
> It is safe to turn on data and instruction caches for mx23.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE
2013-01-28 11:41 ` [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE Fabio Estevam
2013-01-28 12:00 ` Otavio Salvador
2013-01-28 12:46 ` Marek Vasut
@ 2013-02-12 17:51 ` Stefano Babic
2 siblings, 0 replies; 12+ messages in thread
From: Stefano Babic @ 2013-02-12 17:51 UTC (permalink / raw)
To: u-boot
On 28/01/2013 12:41, Fabio Estevam wrote:
> The baudrate is already defined by CONFIG_BAUDRATE and there is no need
> to keep CONFIG_SYS_BAUDRATE_TABLE.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-02-12 17:51 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-28 11:40 [U-Boot] [PATCH 1/3] mx23evk: Remove unneeded 'undef's Fabio Estevam
2013-01-28 11:41 ` [U-Boot] [PATCH 2/3] mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE Fabio Estevam
2013-01-28 12:00 ` Otavio Salvador
2013-01-28 12:46 ` Marek Vasut
2013-01-28 12:53 ` Fabio Estevam
2013-01-28 13:10 ` Marek Vasut
2013-02-12 17:51 ` Stefano Babic
2013-01-28 11:41 ` [U-Boot] [PATCH 3/3] mx23evk: Turn on caches Fabio Estevam
2013-01-28 12:47 ` Marek Vasut
2013-01-28 12:51 ` Fabio Estevam
2013-02-12 17:51 ` Stefano Babic
2013-01-28 11:58 ` [U-Boot] [PATCH 1/3] mx23evk: Remove unneeded 'undef's Otavio Salvador
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox