public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mark Jackson <mpfj-list@mimc.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Allow OMAP2 boards to setup GPMC chipselects.
Date: Tue, 12 Feb 2013 19:20:42 +0000	[thread overview]
Message-ID: <511A960A.8070309@mimc.co.uk> (raw)
In-Reply-To: <20130212170120.GA26121@bill-the-cat>

On 12/02/13 17:01, Tom Rini wrote:
> On Mon, Feb 11, 2013 at 04:29:03PM +0000, Mark Jackson wrote:
>
>> Expose the enable_gpmc_cs_config() function so OMAP2 boards can register
>> GPMC chipselects.
>>
>> Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
>> ---
>>   arch/arm/include/asm/arch-am33xx/sys_proto.h |    2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-am33xx/sys_proto.h b/arch/arm/include/asm/arch-am33xx/sys_proto.h
>> index 588d8de..97ab60d 100644
>> --- a/arch/arm/include/asm/arch-am33xx/sys_proto.h
>> +++ b/arch/arm/include/asm/arch-am33xx/sys_proto.h
>> @@ -35,5 +35,7 @@ void ddr_pll_config(unsigned int ddrpll_M);
>>    void sdelay(unsigned long);
>>   void gpmc_init(void);
>> +void enable_gpmc_cs_config(const u32 *gpmc_config, struct gpmc_cs *cs, u32 base,
>> +			u32 size);
>>   void omap_nand_switch_ecc(int);
>>   #endif
>
> Can you please correct the description?  You're exposing the function
> for am33xx not omap2.  Otherwise fine with me, and I assume you need
> this on a custom board (aside: the function already exists/is used in
> arch/arm/cpu/armv7/am33xx/mem.c).  Are you planning to submit that
> support as well?  Thanks!

Sure ... I'll repost with the comment changed.

Yes ... I've not written my own version, I'm using the existing code.

And, yes, I've a new CPU board I'm working on, which I'll submit later 
(once we've done a hardware re-spin).

Cheers
Mark J.

  reply	other threads:[~2013-02-12 19:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11 16:29 [U-Boot] [PATCH] Allow OMAP2 boards to setup GPMC chipselects Mark Jackson
2013-02-12 17:01 ` Tom Rini
2013-02-12 19:20   ` Mark Jackson [this message]
2013-02-12 19:49     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511A960A.8070309@mimc.co.uk \
    --to=mpfj-list@mimc.co.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox