From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 12 Feb 2013 13:19:18 -0700 Subject: [U-Boot] [PATCH v2 1/2] Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files In-Reply-To: <20130212104109.GA2824@avionic-0098.mockup.avionic-design.de> References: <1360603051-29478-1-git-send-email-twarren@nvidia.com> <1360603051-29478-2-git-send-email-twarren@nvidia.com> <1360603706.1537.2.camel@tellur> <20130211191107.GB25894@avionic-0098.mockup.avionic-design.de> <20130212065155.GB28850@avionic-0098.mockup.avionic-design.de> <20130212104109.GA2824@avionic-0098.mockup.avionic-design.de> Message-ID: <511AA3C6.8060204@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/12/2013 03:41 AM, Thierry Reding wrote: ... > So it turned out that I need to touch U-Boot anyway, so I decided > to give this a spin. I noticed that overriding > CONFIG_ARCH_DEVICE_TREE from the board configuration file doesn't > work currently. What happens is that the autoconf.mk (which is > derived from the board configuration) is included before the CPU > config.mk which sets CONFIG_ARCH_DEVICE_TREE to tegra20 (or > tegra30, tegra114). I came up with the attached patch to set the > variable if not set previously (by the board configuration file). > > Feel free to squash that in your patch series if you deem it a > proper solution. I can also provide a proper separate patch if you > prefer. > diff --git a/arch/arm/cpu/armv7/tegra114/config.mk > b/arch/arm/cpu/armv7/tegra114/config.mk > -CONFIG_ARCH_DEVICE_TREE := tegra114 +CONFIG_ARCH_DEVICE_TREE ?= > tegra114 That looks very odd. What value is CONFIG_ARCH_DEVICE_TREE before that assignment, and why exactly is it wrong?