public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files
Date: Tue, 12 Feb 2013 13:29:10 -0700	[thread overview]
Message-ID: <511AA616.9040200@wwwdotorg.org> (raw)
In-Reply-To: <1360603051-29478-2-git-send-email-twarren@nvidia.com>

On 02/11/2013 10:17 AM, Tom Warren wrote:
> Linux dts files were used for those boards that didn't already
> have sdhci info populated. Tamonten has their own dtsi file with
> common sdhci nodes (sourced from Linux).

> diff --git a/board/nvidia/dts/tegra20-seaboard.dts b/board/nvidia/dts/tegra20-seaboard.dts

>  	sdhci at c8000400 {
> +		status = "okay";
>  		cd-gpios = <&gpio 69 0>; /* gpio PI5 */
>  		wp-gpios = <&gpio 57 0>; /* gpio PH1 */
> -		power-gpios = <&gpio 70 0>; /* gpio PI6 */
> +		power-gpios = <&gpio 70 3>; /* gpio PI6 */
> +		bus-width = <4>;
>  	};

The "3" for the power-gpios flags looks odd, and doesn't match the
kernel. The binding only defines bit 0 for inverted, and doesn't define
bit 1.

  parent reply	other threads:[~2013-02-12 20:29 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11 17:17 [U-Boot] [PATCH v2 0/2] Tegra: MMC: Add DT support for MMC to T20 boards Tom Warren
2013-02-11 17:17 ` [U-Boot] [PATCH v2 1/2] Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files Tom Warren
2013-02-11 17:28   ` Lucas Stach
2013-02-11 17:56     ` Tom Warren
2013-02-11 18:55       ` Lucas Stach
2013-02-11 19:11       ` Thierry Reding
2013-02-11 19:21         ` Tom Warren
2013-02-12  6:51           ` Thierry Reding
2013-02-12 10:41             ` Thierry Reding
2013-02-12 10:53               ` Thierry Reding
2013-02-12 17:36                 ` Tom Warren
2013-02-12 20:19               ` Stephen Warren
2013-02-12 20:47                 ` Thierry Reding
2013-02-12 20:17           ` Stephen Warren
2013-02-12 20:29   ` Stephen Warren [this message]
2013-02-12 20:52     ` Tom Warren
2013-02-11 17:17 ` [U-Boot] [PATCH v2 2/2] Tegra: MMC: Add DT support to MMC driver for all T20 boards Tom Warren
2013-02-11 17:33   ` Lucas Stach
2013-02-11 17:59     ` Tom Warren
2013-02-12 19:24       ` Tom Warren
2013-02-12 19:41         ` Lucas Stach
2013-02-12 19:50           ` Tom Warren
2013-02-12 20:38   ` Stephen Warren
2013-02-12 20:57     ` Tom Warren
2013-02-12 21:06       ` Stephen Warren
2013-02-13 19:59         ` Tom Warren
2013-02-13 20:02           ` Stephen Warren
2013-02-13 20:06             ` Tom Warren
2013-02-13 20:09               ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511AA616.9040200@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox