[U-Boot] [PATCH v2 2/2] Tegra: MMC: Add DT support to MMC driver for all T20 boards

Tom Warren
2013-02-12T20:57:50Z

Stephen,

On Tue, Feb 12, 2013 at 1:38 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 02/11/2013 10:17 AM, Tom Warren wrote:
>> tegra_mmc_init() now parses the DT info for bus width, WP/CD GPIOs, etc.
>> Tested on Seaboard, fully functional.
>>
>> Tamonten boards (medcom-wide, plutux, and tec) use a different/new
>> dtsi file w/common settings.
>
>> diff --git a/drivers/mmc/tegra_mmc.c b/drivers/mmc/tegra_mmc.c
>
>> +static int process_nodes(const void *blob, int node_list[], int count)
> ...
>> + /* build mmc_host[] for each controller */
>> + for (i = 0; i < count; i++) {
> ...
>> + /* Mark position as used */
>> + node_list[i] = -1;
>
> Is that needed? Does anything use that array after this function?
No idea. I took this code from the tegra_i2c.c driver.

>
>> diff --git a/include/configs/medcom-wide.h b/include/configs/medcom-wide.h
>> diff --git a/include/configs/plutux.h b/include/configs/plutux.h
>> diff --git a/include/configs/tec.h b/include/configs/tec.h
>
> In all 3 of those files ...
>
>> #define CONFIG_DEFAULT_DEVICE_TREE tegra20-medcom-wide
>
> Why not change that define ...
>
>> #define CONFIG_OF_CONTROL
>> #define CONFIG_OF_SEPARATE
>> +#undef CONFIG_ARCH_DEVICE_TREE
>> +#define CONFIG_ARCH_DEVICE_TREE tegra20-tamonten
>
> rather than adding that one? All the other Tegra boards only set
> CONFIG_DEFAULT_DEVICE_TREE.

CONFIG_DEFAULT_DEVICE_TREE is the .dts file (board/nvidia/dts).
CONFIG_ARCH_DEVICE_TREE is the .dtsi file (arch/arm/dts). See
Thierry's explanation, also.

>
> Aside from the few comments I and others have made, this series looks good.
Thanks. Working on V3.