From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 05/14] spi: add common fdt SPI driver interface
Date: Wed, 13 Feb 2013 15:40:29 -0700 [thread overview]
Message-ID: <511C165D.50807@wwwdotorg.org> (raw)
In-Reply-To: <1360725802-5518-6-git-send-email-amartin@nvidia.com>
On 02/12/2013 08:23 PM, Allen Martin wrote:
> Add a common interface to fdt based SPI drivers. Each driver is
> represented by a table entry in fdt_spi_drivers[]. If there are
> multiple SPI drivers in the table, the first driver to return success
> from spi_init() will be registered as the SPI driver.
I don't think there should be a global concept of "the" SPI driver;
instances of both SPI blocks exist on Tegra20, so they should be able to
co-exist, using the SFLASH driver for 1 SPI port, and the SLINK driver
for the other 4 ports.
How does this patch interact with any SPI-related device manager work?
> +void spi_init(void)
> +{
> + int i;
> + int num_drivers = sizeof(fdt_spi_drivers) /
> + sizeof(struct fdt_spi_driver);
U-Boot doesn't have an ARSIZE/ARRAY_SIZE macro?
> diff --git a/include/configs/cardhu.h b/include/configs/cardhu.h
> /* SPI */
> #define CONFIG_TEGRA30_SPI
> -#define CONFIG_TEGRA_SLINK_CTRLS 6
> +#define CONFIG_TEGRA30_SPI_CTRLS 6
Should that be in one of the other patches?
next prev parent reply other threads:[~2013-02-13 22:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 3:23 [U-Boot] [PATCH 00/14] tegra114 SPI driver Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 01/14] tegra: spi: rename tegra SPI drivers Allen Martin
2013-02-13 22:30 ` Stephen Warren
2013-02-14 19:58 ` Allen Martin
2013-02-14 20:18 ` Stephen Warren
2013-02-13 22:36 ` Stephen Warren
2013-02-14 20:01 ` Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 02/14] tegra: spi: remove non fdt support Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 03/14] tegra: spi: pull register structs out of headers Allen Martin
2013-02-13 22:32 ` Stephen Warren
2013-02-14 19:20 ` Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 04/14] tegra20: spi: move fdt probe to spi_init Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 05/14] spi: add common fdt SPI driver interface Allen Martin
2013-02-13 22:40 ` Stephen Warren [this message]
2013-02-14 20:07 ` Allen Martin
2013-02-14 20:21 ` Stephen Warren
2013-02-14 21:42 ` Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 06/14] sf: winbond: add W25Q32DW Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 07/14] tegra114: dalmore: add SPI pinmux config Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 08/14] tegra114: fdt: add compatible string for tegra114 SPI ctrl Allen Martin
2013-02-13 22:51 ` Stephen Warren
2013-02-13 3:23 ` [U-Boot] [PATCH 09/14] tegra114: fdt: add CAR block Allen Martin
2013-02-13 22:46 ` Stephen Warren
2013-02-13 3:23 ` [U-Boot] [PATCH 10/14] tegra114: fdt: add apbdma block Allen Martin
2013-02-13 22:48 ` Stephen Warren
2013-02-13 3:23 ` [U-Boot] [PATCH 11/14] tegra114: fdt: add SPI blocks Allen Martin
2013-02-13 22:52 ` Stephen Warren
2013-02-13 3:23 ` [U-Boot] [PATCH 12/14] tegra114: dalmore: fdt: enable dalmore SPI controller Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 13/14] tegra114: add SPI driver Allen Martin
2013-02-13 22:59 ` Stephen Warren
2013-02-14 14:32 ` Simon Glass
2013-02-14 21:49 ` Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 14/14] tegra114: dalmore: config: enable SPI Allen Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511C165D.50807@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox