From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Introduced btrfs file-system with btrload command
Date: Thu, 14 Feb 2013 11:42:50 +0100 [thread overview]
Message-ID: <511CBFAA.8000001@denx.de> (raw)
In-Reply-To: <CAP9ODKot=Q+aad0+Ec8AvmENNm_xTAfFC8Eij3xZp7k2XvsDLQ@mail.gmail.com>
On 14.02.2013 11:20, Otavio Salvador wrote:
>> diff --git a/Makefile b/Makefile
>> index 3305e8c..8d2855a 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -270,7 +270,8 @@ LIBS-y += fs/libfs.o \
>> fs/reiserfs/libreiserfs.o \
>> fs/ubifs/libubifs.o \
>> fs/yaffs2/libyaffs2.o \
>> - fs/zfs/libzfs.o
>> + fs/zfs/libzfs.o\
>
> Missed space after .o
Yes. And please keep the list sorted.
>> + fs/btrfs/libbtrfs.o
>> LIBS-y += net/libnet.o
>> LIBS-y += disk/libdisk.o
>> LIBS-y += drivers/bios_emulator/libatibiosemu.o
>> diff --git a/common/Makefile b/common/Makefile
>> index 54fcc81..4abf26b 100644
>> --- a/common/Makefile
>> +++ b/common/Makefile
>> @@ -96,6 +96,7 @@ COBJS-$(CONFIG_SYS_HUSH_PARSER) += cmd_exit.o
>> COBJS-$(CONFIG_CMD_EXT4) += cmd_ext4.o
>> COBJS-$(CONFIG_CMD_EXT2) += cmd_ext2.o
>> COBJS-$(CONFIG_CMD_FAT) += cmd_fat.o
>> +COBJS-$(CONFIG_CMD_FAT) += cmd_btr.o
>
> Something wrong here, no?!?! ;-) FAT?!?
Yep.
> I did not test the code yet but it'd be nice if you could fix those
> and resend. Did you pass the patch in checkpatch.pl script? I think it
> has some code styles issues as well but I didn't check it myself.
> Please do when preparing v2.
>
> Please give a look at http://www.denx.de/wiki/U-Boot/Patches I think
> it is proper documented there.
Ack. One exception though might be, that the original code where this is
copied from (syslinux) has these coding style issues. And it could make
sense to leave the code as is, to make future syncing easier (diff for
changes etc).
Thanks,
Stefan
next prev parent reply other threads:[~2013-02-14 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 18:07 [U-Boot] [PATCH] btrfs support in uboot Adnan Ali
2013-02-13 18:07 ` [U-Boot] [PATCH] Introduced btrfs file-system with btrload command Adnan Ali
2013-02-14 10:20 ` Otavio Salvador
2013-02-14 10:42 ` Stefan Roese [this message]
2013-02-14 10:59 ` Adnan Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511CBFAA.8000001@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox