From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adnan Ali <adnan.ali@codethink.co.uk>
Date: Thu, 14 Feb 2013 10:59:29 +0000
Subject: [U-Boot] [PATCH] Introduced btrfs file-system with btrload
	command
In-Reply-To: <511CBFAA.8000001@denx.de>
References: <1360778852-22948-1-git-send-email-adnan.ali@codethink.co.uk>
	<1360778852-22948-2-git-send-email-adnan.ali@codethink.co.uk>
	<CAP9ODKot=Q+aad0+Ec8AvmENNm_xTAfFC8Eij3xZp7k2XvsDLQ@mail.gmail.com>
	<511CBFAA.8000001@denx.de>
Message-ID: <511CC391.2040107@codethink.co.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 14/02/13 10:42, Stefan Roese wrote:
> On 14.02.2013 11:20, Otavio Salvador wrote:
>>> diff --git a/Makefile b/Makefile
>>> index 3305e8c..8d2855a 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -270,7 +270,8 @@ LIBS-y += fs/libfs.o \
>>>          fs/reiserfs/libreiserfs.o \
>>>          fs/ubifs/libubifs.o \
>>>          fs/yaffs2/libyaffs2.o \
>>> -       fs/zfs/libzfs.o
>>> +       fs/zfs/libzfs.o\
>> Missed space after .o
> Yes. And please keep the list sorted.
     Ack
>
>>> +        fs/btrfs/libbtrfs.o
>>>   LIBS-y += net/libnet.o
>>>   LIBS-y += disk/libdisk.o
>>>   LIBS-y += drivers/bios_emulator/libatibiosemu.o
>>> diff --git a/common/Makefile b/common/Makefile
>>> index 54fcc81..4abf26b 100644
>>> --- a/common/Makefile
>>> +++ b/common/Makefile
>>> @@ -96,6 +96,7 @@ COBJS-$(CONFIG_SYS_HUSH_PARSER) += cmd_exit.o
>>>   COBJS-$(CONFIG_CMD_EXT4) += cmd_ext4.o
>>>   COBJS-$(CONFIG_CMD_EXT2) += cmd_ext2.o
>>>   COBJS-$(CONFIG_CMD_FAT) += cmd_fat.o
>>> +COBJS-$(CONFIG_CMD_FAT) += cmd_btr.o
>> Something wrong here, no?!?! ;-) FAT?!?
> Yep.
      I realized it after i sent the patch :/
>
>> I did not test the code yet but it'd be nice if you could fix those
>> and resend. Did you pass the patch in checkpatch.pl script? I think it
>> has some code styles issues as well but I didn't check it myself.
>> Please do when preparing v2.
>>
>> Please give a look at http://www.denx.de/wiki/U-Boot/Patches I think
>> it is proper documented there.
> Ack. One exception though might be, that the original code where this is
> copied from (syslinux) has these coding style issues. And it could make
> sense to leave the code as is, to make future syncing easier (diff for
> changes etc).
>
> Thanks,
> Stefan
>