From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/14] tegra: spi: rename tegra SPI drivers
Date: Thu, 14 Feb 2013 13:18:48 -0700 [thread overview]
Message-ID: <511D46A8.2080200@wwwdotorg.org> (raw)
In-Reply-To: <20130214195823.GB32695@badger>
On 02/14/2013 12:58 PM, Allen Martin wrote:
> On Wed, Feb 13, 2013 at 02:30:26PM -0800, Stephen Warren wrote:
>> On 02/12/2013 08:23 PM, Allen Martin wrote:
>>> Rename tegra SPI drivers to tegra20_spi and tegra30_spi in preparation
>>> for commonization and addition of tegra114_spi.
>>
>> This isn't logically quite right. Both types (sflash, slink) of SPI
>> controller actually exist on Tegra20, so it isn't right to name them
>> after the different chips. It is true that only one is kept for Tegra30
>> (slink). As such, it might make sense to simply drop this patch.
>
> Mostly my intention here was to try to make the SPI driver naming less
> confusing and to make room for the "new" tegra114 SPI driver. What do
> you think of the following:
>
> tegra_sflash: tegra20 sflash driver
> tegra_slink: tegra20 and tegra30 slink driver
I'd suggest naming those tegra20_*.
> tegra_spi: tegra114 and later spi driver
... and that tegra114_spi. That way, it's obvious when those IP blocks
were introduced, which will help people know which driver they care about.
Looking closer at the Tegra114 TRM, it looks like they did declare
"slink" a deprecated name, so the Tegra114 block really should be called
"SPI" as you have it. So, disregard my comments about the compatible
value; nvidia,tegra114-spi looks like the correct choice now.
next prev parent reply other threads:[~2013-02-14 20:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 3:23 [U-Boot] [PATCH 00/14] tegra114 SPI driver Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 01/14] tegra: spi: rename tegra SPI drivers Allen Martin
2013-02-13 22:30 ` Stephen Warren
2013-02-14 19:58 ` Allen Martin
2013-02-14 20:18 ` Stephen Warren [this message]
2013-02-13 22:36 ` Stephen Warren
2013-02-14 20:01 ` Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 02/14] tegra: spi: remove non fdt support Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 03/14] tegra: spi: pull register structs out of headers Allen Martin
2013-02-13 22:32 ` Stephen Warren
2013-02-14 19:20 ` Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 04/14] tegra20: spi: move fdt probe to spi_init Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 05/14] spi: add common fdt SPI driver interface Allen Martin
2013-02-13 22:40 ` Stephen Warren
2013-02-14 20:07 ` Allen Martin
2013-02-14 20:21 ` Stephen Warren
2013-02-14 21:42 ` Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 06/14] sf: winbond: add W25Q32DW Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 07/14] tegra114: dalmore: add SPI pinmux config Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 08/14] tegra114: fdt: add compatible string for tegra114 SPI ctrl Allen Martin
2013-02-13 22:51 ` Stephen Warren
2013-02-13 3:23 ` [U-Boot] [PATCH 09/14] tegra114: fdt: add CAR block Allen Martin
2013-02-13 22:46 ` Stephen Warren
2013-02-13 3:23 ` [U-Boot] [PATCH 10/14] tegra114: fdt: add apbdma block Allen Martin
2013-02-13 22:48 ` Stephen Warren
2013-02-13 3:23 ` [U-Boot] [PATCH 11/14] tegra114: fdt: add SPI blocks Allen Martin
2013-02-13 22:52 ` Stephen Warren
2013-02-13 3:23 ` [U-Boot] [PATCH 12/14] tegra114: dalmore: fdt: enable dalmore SPI controller Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 13/14] tegra114: add SPI driver Allen Martin
2013-02-13 22:59 ` Stephen Warren
2013-02-14 14:32 ` Simon Glass
2013-02-14 21:49 ` Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 14/14] tegra114: dalmore: config: enable SPI Allen Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511D46A8.2080200@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox