public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 0/3] Tegra: MMC: Add DT support for MMC to T20 boards
Date: Thu, 14 Feb 2013 16:27:16 -0700	[thread overview]
Message-ID: <511D72D4.8040106@wwwdotorg.org> (raw)
In-Reply-To: <1360791890-6644-1-git-send-email-twarren@nvidia.com>

On 02/13/2013 02:44 PM, Tom Warren wrote:
> This patchset adds device-tree support to the Tegra MMC driver.
> All device config is done via properties in the DT files instead
> of hard-coded config options/function arguments.
> 
> I've tested this on my Seaboard and everything works fine,
> including card detect. For the other T20 boards, I've used
> the Linux kernel DTS files for the sdhci nodes where there
> wasn't one already, or expanded the info that was already
> there. Everything builds fine, but I haven't tested anything
> but Seaboard.

With the incremental patch below applied,

Tested-by: Stephen Warren <swarren@nvidia.com>
On: Harmony, Seaboard(really Springbank), Ventana, Whistler,
Paz00/AC100, TrimSlice.

> commit a5be5907d77eb4ca18dd9a11dd09183148c9d1b2
> Author: Stephen Warren <swarren@nvidia.com>
> Date:   Thu Feb 14 16:02:24 2013 -0700
> 
>     Fix MMC DT rework
> 
> diff --git a/drivers/mmc/tegra_mmc.c b/drivers/mmc/tegra_mmc.c
> index e8e8512..630f6bd 100644
> --- a/drivers/mmc/tegra_mmc.c
> +++ b/drivers/mmc/tegra_mmc.c
> @@ -497,7 +497,6 @@ static int do_mmc_init(int dev_index)
>         struct mmc_host *host;
>         char gpusage[12]; /* "SD/MMCn PWR" or "SD/MMCn CD" */
>         struct mmc *mmc;
> -       int card_det = 0;
>  
>         /* DT should have been read & host config filled in */
>         host = &mmc_host[dev_index];
> @@ -514,16 +513,15 @@ static int do_mmc_init(int dev_index)
>         if (fdt_gpio_isvalid(&host->pwr_gpio)) {
>                 sprintf(gpusage, "SD/MMC%d PWR", dev_index);
>                 gpio_request(host->pwr_gpio.gpio, gpusage);
> -               fdtdec_set_gpio(&host->pwr_gpio, 1);
> +               gpio_direction_output(host->pwr_gpio.gpio, 1);
>                 debug(" Power GPIO name = %s\n", host->pwr_gpio.name);
>         }
>  
>         if (fdt_gpio_isvalid(&host->cd_gpio)) {
>                 sprintf(gpusage, "SD/MMC%d CD", dev_index);
>                 gpio_request(host->cd_gpio.gpio, gpusage);
> -               card_det = fdtdec_get_gpio(&host->cd_gpio);
> +               gpio_direction_input(host->cd_gpio.gpio);
>                 debug(" CD GPIO name = %s\n", host->cd_gpio.name);
> -               debug("%s: CD state = %d\n", __func__, card_det);
>         }
>  
>         mmc = &mmc_dev[dev_index];

  parent reply	other threads:[~2013-02-14 23:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 21:44 [U-Boot] [PATCH v3 0/3] Tegra: MMC: Add DT support for MMC to T20 boards Tom Warren
2013-02-13 21:44 ` [U-Boot] [PATCH v3 1/3] Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files Tom Warren
2013-02-14  0:10   ` Stephen Warren
2013-02-14 16:14     ` Tom Warren
2013-02-14 20:24       ` Stephen Warren
2013-02-15 11:58         ` Lucas Stach
2013-02-20 18:04           ` Tom Warren
2013-02-13 21:44 ` [U-Boot] [PATCH v3 2/3] Tegra: fdt: tamonten: Add common tamonten.dtsi file from linux Tom Warren
2013-02-14  0:11   ` Stephen Warren
2013-02-14  7:18   ` Thierry Reding
2013-02-13 21:44 ` [U-Boot] [PATCH v3 3/3] Tegra: MMC: Add DT support to MMC driver for all T20 boards Tom Warren
2013-02-14  0:17   ` Stephen Warren
2013-02-14  4:47     ` Simon Glass
2013-02-14 15:42     ` Tom Warren
2013-02-14  7:19 ` [U-Boot] [PATCH v3 0/3] Tegra: MMC: Add DT support for MMC to " Thierry Reding
2013-02-14 15:33   ` Tom Warren
2013-02-14 19:25   ` Thierry Reding
2013-02-14 23:27 ` Stephen Warren [this message]
2013-02-14 23:33   ` Tom Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511D72D4.8040106@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox