From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 14 Feb 2013 20:05:30 -0700 Subject: [U-Boot] [PATCH V5 REPOST 6/7] mmc: add bcm2835 driver In-Reply-To: <20130203122728.45189b85@lilith> References: <1358303219-17503-1-git-send-email-swarren@wwwdotorg.org> <1358303219-17503-6-git-send-email-swarren@wwwdotorg.org> <20130203122728.45189b85@lilith> Message-ID: <511DA5FA.60804@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/03/2013 04:27 AM, Albert ARIBAUD wrote: > On Tue, 15 Jan 2013 19:26:58 -0700, Stephen Warren > wrote: > >> This adds a simple driver for the BCM2835's SD controller. >> >> Workarounds are implemented for: >> * Register writes can't be too close to each-other in time, or they will >> be lost. >> * Register accesses must all be 32-bit, so implement custom accessors. >> >> This code was extracted from: >> git://github.com/gonzoua/u-boot-pi.git master >> which was created by Oleksandr Tymoshenko. >> >> Portions of the code there were obviously based on the Linux kernel at: >> git://github.com/raspberrypi/linux.git rpi-3.6.y >> commit f5b930b "Main bcm2708 linux port" signed-off-by Dom Cobley. >> >> swarren changed the following for upstream: >> * Removed hack udelay()s in bcm2835_sdhci_raw_writel(); setting >> SDHCI_QUIRK_WAIT_SEND_CMD appears to solve the issues. >> * Remove register logging from read*/write* functions. >> * Sort out confusion with min/max_freq values passed to add_sdhci(). >> * Use more descriptive variable names and calculations in IO accessors. >> * Simplified and commented twoticks_delay calculation. >> * checkpatch fixes. >> >> Cc: Andy Fleming >> Signed-off-by: Oleksandr Tymoshenko >> Signed-off-by: Stephen Warren >> --- >> Andy, could you please ack this so Albert can take it through the ARM tree; >> patch 7/7 depends is an ARM patch and depends on this. Thanks. ... > Andy, can you give a formal Acked-By to this patch as per Stephen's > request? Albert, perhaps you could apply patches 1-5 without waiting on this; the MMC driver could be added once Andy ack's it.