From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Nelson <eric.nelson@boundarydevices.com>
Date: Mon, 18 Feb 2013 06:59:56 -0700
Subject: [U-Boot] [PATCH 6/6] i.MX6: Add DDR controller registers
In-Reply-To: <AD13664F485EE54694E29A7F9D5BE1AF5F4D93@039-SN2MPN1-021.039d.mgd.msft.net>
References: <1361129058-27988-1-git-send-email-eric.nelson@boundarydevices.com>
	<1361129058-27988-7-git-send-email-eric.nelson@boundarydevices.com>
	<AD13664F485EE54694E29A7F9D5BE1AF5F4D93@039-SN2MPN1-021.039d.mgd.msft.net>
Message-ID: <512233DC.9000505@boundarydevices.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Thanks for the review Jason,

On 02/17/2013 10:16 PM, Liu Hui-R64343 wrote:
>> -----Original Message-----
>> From: Eric Nelson [mailto:eric.nelson at boundarydevices.com]
>> Sent: Monday, February 18, 2013 3:24 AM
>> To: u-boot at lists.denx.de
>> Cc: sbabic at denx.de; Liu Hui-R64343; Estevam Fabio-R49496;
>> troy.kisky at boundarydevices.com; Eric Nelson
>> Subject: [PATCH 6/6] i.MX6: Add DDR controller registers
>>
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>> ---
>> arch/arm/include/asm/arch-mx6/mx6-ddr.h   |   85
>> +++++++++++++++++++++++++++++
>> arch/arm/include/asm/arch-mx6/mx6dl-ddr.h |   71
>> ++++++++++++++++++++++++
>> arch/arm/include/asm/arch-mx6/mx6q-ddr.h  |   69
>> +++++++++++++++++++++++
>> 3 files changed, 225 insertions(+)
>> create mode 100644 arch/arm/include/asm/arch-mx6/mx6-ddr.h
>> create mode 100644 arch/arm/include/asm/arch-mx6/mx6dl-ddr.h
>> create mode 100644 arch/arm/include/asm/arch-mx6/mx6q-ddr.h
>
> I did not see any user of these files, what the purpose of this?
>
These will be used in the memory configuration for nitrogen6x,
that will build for dual/quad or dual-lite/solo as discussed here:
	http://lists.denx.de/pipermail/u-boot/2013-January/145562.html

I'm holding that off waiting for commentary on these to
avoid thrashing.

>>
>> diff --git a/arch/arm/include/asm/arch-mx6/mx6-ddr.h
>> b/arch/arm/include/asm/arch-mx6/mx6-ddr.h
>> new file mode 100644
>> index 0000000..4d18ede
>> --- /dev/null
>> +++ b/arch/arm/include/asm/arch-mx6/mx6-ddr.h
>> @@ -0,0 +1,85 @@
>> +/*
>> + * Copyright (C) 2012 Boundary Devices Inc.
>
> Either 2013 or 2012 - 2013?
>

Can you tell this patch has been lingering?

>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> +
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> +
>> + * You should have received a copy of the GNU General Public License
>> +along
>> + * with this program; if not, write to the Free Software Foundation,
>> +Inc.,
>> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>> + */
>> +#ifndef __ASM_ARCH_MX6_DDR_H__
>> +#define __ASM_ARCH_MX6_DDR_H__
>> +
>> +#ifdef CONFIG_MX6Q
>> +#include "mx6q-ddr.h"
>> +#else
>> +#if defined(CONFIG_MX6DL) || defined(CONFIG_MX6S) #include
>> +"mx6dl-ddr.h"
>> +#else
>> +#error "Please select cpu"
>> +#endif	/* CONFIG_MX6DL or CONFIG_MX6S */
>> +#endif	/* CONFIG_MX6Q */
>> +
>> +#define MMDC_P0_MDCTL		0x021b0000
>
> I also prefer to add MX6_ prefix,
>

Will fix in V2 along with your "Ditto" comments.

...