From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 16/20] Roll crc32 into hash infrastructure
Date: Mon, 18 Feb 2013 12:05:10 -0500 [thread overview]
Message-ID: <51225F46.5050200@ti.com> (raw)
In-Reply-To: <CAPnjgZ3UQ3j-Y=ZfaD940EO1n7yB3uYnpooW0Zr8ASaj-tTwfQ@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/18/2013 11:36 AM, Simon Glass wrote:
> Hi Wolfgang,
>
> On Mon, Feb 18, 2013 at 3:35 AM, Wolfgang Denk <wd@denx.de> wrote:
>> Dear Tom,
>>
>> In message <51216721.1010603@ti.com> you wrote:
>>>
>>> There's another thread I don't have yet (and I don't have this
>>> one in gmail yet even). But, I am OK with custodians using
>>> their repos, but not the master branch, for unrelated but
>>> otherwise good patches. I'm also fine with patchwork bundles. I
>>> suppose we could use the staging repository for these changes
>>> instead.
>>
>> What I mostly object about there is that these patches would go
>> into mainline basicly unreviewed, as patch submission and pull
>> request is all done from a single person, with no other feedback
>> on the patches at all. And this affects a lot of common code...
>
> Fair enough. I suspect a number of people scan the code, but few
> feel invested enough to formally Ack it. Also, providing a full
> review of such a series can take quite a bit of time. Against
> that, I think it is better to get code in and tested than have it
> sit around until just before the next release.
[snip]
>> So there are changes all over the place, including a growth of
>> the memory footprint. I think this needs at least minimal
>> review.
>
> We need more reviewers I think.
This is where I'm trying to find a good balance right now. If we just
wait for reviewed-by lines to fly by, things will sit forever. Partly
because enough folks don't feel like they "own" things enough to risk
saying they reviewed something that turns out later to have a bug.
And partly there's just not enough folks reading patches. I do try
and give things some sort of read-over when it's the person posting
who is doing the merging, especially for common rather than "their
area" code.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRIl9FAAoJENk4IS6UOR1WJqMP/ie04KKI6NpMPDei9QSJ9+qg
peFMXyVXoNWVZ0OuVSgVYOyBNtTmZeUmNsyamtE/1QifAWX6F2lwXHl2teYcebMk
7Fn/N3uzoVisfcFhY3Ec0dgBigYbRm5hiSHF7qzBkS78FfI5XSFaR/XjkshCgLlC
i5Vf8Gh6ilb67fLumzxnXU2LLpbfcoOoT7iMLX0C5SFkx9sjo4k/5/WC64jsx8IS
NQiaoFX3Ow7uU63G7jEJ4hiqXsp2ulWZTBA4ynN7ydGYiPo+sRXoLRaBYB9yAkRQ
3Uj1a101VX+9LWdNoMRpqv6W3gq75+8nSggovK0DmxtF4X5PaF17Xmpc8dBTT9rE
cCIkePKDNgg6QjTAtCxk7+nw997JSjrj1nV0R2+Jm225tby4hIjmnIfnCNgeYbbI
II7+ecaUl4w+GxB1SgjFLmEyW0unDsYZauT4sXxSdBp/UOrs4I3XYW4gFofifMcB
peJELQYVUHnXblZ+xR+8zY3URsn2vNRxNq5fUDWMUADgvwecfvWFeKaVGDA+aWHs
vNFKWayZbt5MpqG4aQJ4mzIhf9avNytf8BSSQ+LFp53xOl5f08OsioN9+4H3rOND
LRuiMZ5wtrlJea3Eoi3PFXeO/l4N4eKvDNbwNSwDbS4EZj+4mZbGrNxGglcQK3C+
1EM1fpRioWEXpGaMpmKV
=W6Pn
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-02-18 17:05 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-26 18:56 [U-Boot] [PATCH 0/20] Improvements to memory, hashing functions for sandbox Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 01/20] Tidy up error checking and fix bug in hash command Simon Glass
2013-02-15 23:48 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 02/20] Update print_buffer() to use const Simon Glass
2013-02-15 23:49 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 03/20] sandbox: Improve sandbox serial port keyboard interface Simon Glass
2013-02-15 23:49 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 04/20] sandbox: Add un/map_sysmen() to deal with sandbox's ram_buf Simon Glass
2013-02-15 23:51 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 05/20] sandbox: Change memory commands to use map_physmem Simon Glass
2013-02-15 23:51 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 06/20] Split out the memory tests into separate functions Simon Glass
2013-02-15 23:52 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 07/20] Use common mtest iteration counting Simon Glass
2013-02-15 23:52 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 08/20] Fix mtest indenting Simon Glass
2013-02-15 23:53 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 09/20] Bring mtest putc() into common code Simon Glass
2013-02-15 23:53 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 10/20] Reduce casting in mtest Simon Glass
2013-02-15 23:54 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 11/20] Update set_working_fdt_addr() to use setenv_addr() Simon Glass
2013-02-14 20:00 ` [U-Boot] [PATCH] common/main: move set_working_fdt_addr to enable usage of $fdtaddr Barak Wasserstrom
2013-02-15 23:54 ` [U-Boot] [PATCH 11/20] Update set_working_fdt_addr() to use setenv_addr() Simon Glass
2013-02-25 10:52 ` [U-Boot] [PATCH] common/main: move set_working_fdt_addr to enable usage of $fdtaddr Barak Wasserstrom
2013-02-27 18:48 ` Barak Wasserstrom
2012-12-26 18:57 ` [U-Boot] [PATCH 12/20] common: Use new numeric setenv functions Simon Glass
2013-02-15 23:55 ` Simon Glass
2013-02-18 22:08 ` Tom Rini
2013-02-24 17:45 ` Simon Glass
2013-02-24 20:53 ` Tom Rini
2013-02-25 3:42 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 13/20] drivers: " Simon Glass
2013-02-15 23:55 ` Simon Glass
2013-02-18 22:37 ` Tom Rini
2012-12-26 18:57 ` [U-Boot] [PATCH 14/20] net: " Simon Glass
2013-02-15 23:56 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 15/20] image: Use crc header file instead of C prototypes Simon Glass
2012-12-26 22:02 ` Marek Vasut
2013-02-15 23:56 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 16/20] Roll crc32 into hash infrastructure Simon Glass
2013-02-15 23:57 ` Simon Glass
2013-02-17 20:53 ` Wolfgang Denk
2013-02-17 21:34 ` Simon Glass
2013-02-17 23:26 ` Tom Rini
2013-02-18 11:35 ` Wolfgang Denk
2013-02-18 16:36 ` Simon Glass
2013-02-18 17:05 ` Tom Rini [this message]
2013-02-18 17:06 ` Simon Glass
2013-02-18 22:45 ` Tom Rini
2013-02-19 5:24 ` Simon Glass
2013-02-20 17:04 ` Simon Glass
2013-02-18 23:14 ` Wolfgang Denk
2012-12-26 18:57 ` [U-Boot] [PATCH 17/20] sandbox: config: Enable hash functions and mtest Simon Glass
2013-02-15 23:57 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 18/20] Move CONFIG_SYS_MEMTEST_SCRATCH #ifdef to top of file Simon Glass
2013-02-15 23:58 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 19/20] sandbox: Update mtest to fix crashes Simon Glass
2013-02-15 23:58 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 20/20] sandbox: Allow hash functions to work correctly Simon Glass
2013-02-15 23:58 ` Simon Glass
2013-02-18 22:49 ` [U-Boot] [PATCH 0/20] Improvements to memory, hashing functions for sandbox Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51225F46.5050200@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox